Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider.h

Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/geolocation/blimp_location_provider.h
diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.h b/blimp/engine/feature/geolocation/blimp_location_provider.h
index d3d16f22a9041915f79a05dd2465a446497b9479..07df427f28885c15875e5166ef52daea95415f5f 100644
--- a/blimp/engine/feature/geolocation/blimp_location_provider.h
+++ b/blimp/engine/feature/geolocation/blimp_location_provider.h
@@ -5,6 +5,8 @@
#ifndef BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
#define BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
+#include "base/memory/weak_ptr.h"
+#include "blimp/common/proto/geolocation.pb.h"
#include "content/public/browser/location_provider.h"
#include "content/public/common/geoposition.h"
@@ -14,7 +16,23 @@ namespace engine {
// Location provider for Blimp using the device's provider over the network.
class BlimpLocationProvider : public content::LocationProvider {
public:
- BlimpLocationProvider();
+ // A delegate that implements a subset of LocationProvider's functions.
+ class Delegate {
+ public:
+ using GeopositionReceivedCallback =
+ base::Callback<void(const content::Geoposition&)>;
+
+ virtual ~Delegate() {}
+
+ virtual void RequestAccuracy(
+ GeolocationSetInterestLevelMessage::Level level) = 0;
+ virtual void RequestRefresh() = 0;
+
Kevin M 2016/07/21 17:37:05 remove newline
CJ 2016/07/21 22:04:46 Done.
+ virtual void SetUpdateCallback(
+ const GeopositionReceivedCallback& callback) = 0;
+ };
+
+ explicit BlimpLocationProvider(base::WeakPtr<Delegate> delegate);
~BlimpLocationProvider() override;
// content::LocationProvider implementation.
@@ -23,16 +41,17 @@ class BlimpLocationProvider : public content::LocationProvider {
void GetPosition(content::Geoposition* position) override;
void RequestRefresh() override;
void OnPermissionGranted() override;
-
- private:
- void NotifyCallback(const content::Geoposition& position);
- void OnLocationResponse(const content::Geoposition& position);
void SetUpdateCallback(
const LocationProviderUpdateCallback& callback) override;
- LocationProviderUpdateCallback callback_;
+ private:
+ // This delegate handles a subset of the LocationProvider functionality.
+ base::WeakPtr<Delegate> delegate_;
+
+ content::Geoposition cached_position_;
- content::Geoposition position_;
+ // Indicates whether a successful StartProvider call has occured.
Wez 2016/07/22 01:18:58 nit: Suggest "True if a ..."
CJ 2016/07/22 20:03:30 Done.
+ bool is_started_;
DISALLOW_COPY_AND_ASSIGN(BlimpLocationProvider);
};

Powered by Google App Engine
This is Rietveld 408576698