Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4082)

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider.cc

Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: In response to Wez's #23 comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/geolocation/blimp_location_provider.cc
diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.cc b/blimp/engine/feature/geolocation/blimp_location_provider.cc
index de86b9fc1e65b31384c8cbdd43cca52128e388ca..c5149a17a5d149a4aa17ba927538278557b15fd6 100644
--- a/blimp/engine/feature/geolocation/blimp_location_provider.cc
+++ b/blimp/engine/feature/geolocation/blimp_location_provider.cc
@@ -4,6 +4,9 @@
#include "blimp/engine/feature/geolocation/blimp_location_provider.h"
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/memory/weak_ptr.h"
#include "content/public/common/geoposition.h"
namespace blimp {
@@ -15,12 +18,21 @@ BlimpLocationProvider::~BlimpLocationProvider() {
StopProvider();
}
+void BlimpLocationProvider::SetDelegate(
+ base::WeakPtr<BlimpLocationProvider::Delegate> delegate) {
+ DCHECK(delegate);
+ DCHECK(!delegate_);
+
+ delegate_ = delegate;
+}
+
bool BlimpLocationProvider::StartProvider(bool high_accuracy) {
- NOTIMPLEMENTED();
+ delegate_->StartProvider(high_accuracy);
return true;
}
void BlimpLocationProvider::StopProvider() {
+ delegate_->StopProvider();
}
void BlimpLocationProvider::GetPosition(content::Geoposition* position) {
@@ -30,32 +42,16 @@ void BlimpLocationProvider::GetPosition(content::Geoposition* position) {
}
void BlimpLocationProvider::RequestRefresh() {
- NOTIMPLEMENTED();
+ delegate_->RequestRefresh();
}
void BlimpLocationProvider::OnPermissionGranted() {
RequestRefresh();
- NOTIMPLEMENTED();
-}
-
-void BlimpLocationProvider::NotifyCallback(
- const content::Geoposition& position) {
- DCHECK(!callback_.is_null());
-
- callback_.Run(this, position);
-}
-
-void BlimpLocationProvider::OnLocationResponse(
- const content::Geoposition& position) {
- NotifyCallback(position);
- NOTIMPLEMENTED();
}
void BlimpLocationProvider::SetUpdateCallback(
const LocationProviderUpdateCallback& callback) {
- DCHECK(!callback.is_null());
-
- callback_ = callback;
+ delegate_->SetUpdateCallback(base::Bind(callback, base::Unretained(this)));
}
} // namespace engine

Powered by Google App Engine
This is Rietveld 408576698