Adds EngineGeolocationFeature for Blimp Geolocation project.

blimp/engine/feature/geolocation/blimp_location_provider.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
 #define BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
 
 #include "content/public/browser/location_provider.h"
 #include "content/public/common/geoposition.h"
 
 namespace blimp {
 namespace engine {
 
 // Location provider for Blimp using the device's provider over the network.
 class BlimpLocationProvider : public content::LocationProvider {
  public:
+  // A delegate that handles geolocation related outcoming and incoming events.
+  class BlimpLocationProviderDelegate {

[Kevin M, 2016/06/29 17:52:55]

nit: Just "Delegate" should suffice

[CJ, 2016/07/11 23:21:06]

Done.

+   public:
+    virtual ~BlimpLocationProviderDelegate() {};
+
+    // Notifies the client that the is listening engine is listening for
+    // geoposition information with the given accuracy.
+    virtual void SendUpdateListenStateMessage(bool enable_high_accuracy) = 0;

[Kevin M, 2016/06/29 17:52:55]

Remove "Send" and "Message" from these method names. The message sending aspect
shouldn't be exposed to this layer.

[CJ, 2016/07/11 23:21:07]

Done.

+
+    // Notifies the client that the engine is no longer listening for
+    // updates.
+    virtual void SendStopListenStateMessage() = 0;

[Kevin M, 2016/06/29 17:52:55]

I thought we were just going to have Update, not Start/Stop (or Update/Stop in
this case)?

[CJ, 2016/07/11 23:21:06]

It is expressed that way in the proto, but I thought it would make sense just to
have separate functions. 

+
+    // Requests an updated geoposition from the client.
+    virtual void SendRequestRefreshMessage() = 0;
+  };
+
   BlimpLocationProvider();
   ~BlimpLocationProvider() override;
 
   // content::LocationProvider implementation.
   bool StartProvider(bool high_accuracy) override;
   void StopProvider() override;
   void GetPosition(content::Geoposition* position) override;
   void RequestRefresh() override;
   void OnPermissionGranted() override;
+  void OnLocationResponse(const content::Geoposition& position);
+  void SetDelegate(BlimpLocationProviderDelegate* delegate);

[Kevin M, 2016/06/29 17:52:55]

These methods should be placed above the "implementation" block

[CJ, 2016/07/11 23:21:06]

Done.

 
  private:
+  BlimpLocationProviderDelegate* delegate_ = nullptr;
+
   void NotifyCallback(const content::Geoposition& position);
-  void OnLocationResponse(const content::Geoposition& position);
   void SetUpdateCallback(
       const LocationProviderUpdateCallback& callback) override;
 
   LocationProviderUpdateCallback callback_;
 
   content::Geoposition position_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpLocationProvider);
 };
 
 }  // namespace engine
 }  // namespace blimp
 
 #endif  // BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_