Adds EngineGeolocationFeature for Blimp Geolocation project.

blimp/engine/feature/geolocation/blimp_location_provider.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
 #define BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_
 
+#include "base/memory/weak_ptr.h"
+#include "blimp/common/proto/geolocation.pb.h"
 #include "content/public/browser/location_provider.h"
 #include "content/public/common/geoposition.h"
 
 namespace blimp {
 namespace engine {
 
 // Location provider for Blimp using the device's provider over the network.
 class BlimpLocationProvider : public content::LocationProvider {
  public:
-  BlimpLocationProvider();
+  // A delegate that handles outgoing geolocation messages.

[Kevin M, 2016/07/19 16:01:41]

nit: messages are N/A at this layer

[CJ, 2016/07/19 20:35:58]

Done.

+  class Delegate {
+   public:
+    virtual ~Delegate() {}
+
+    // Implements subset of LocationProvider's functions.
+    virtual void RequestAccuracy(
+        GeolocationSetInterestLevelMessage::Level level) = 0;
+    virtual void RequestRefresh() = 0;
+
+    virtual void SetUpdateCallback(
+        const base::Callback<void(const content::Geoposition&)>& callback) = 0;

[Kevin M, 2016/07/19 16:01:41]

suggestion: create an alias for the callback type with "using"

[CJ, 2016/07/19 20:35:58]

Done.

+  };
+
+  explicit BlimpLocationProvider(base::WeakPtr<Delegate> delegate);
   ~BlimpLocationProvider() override;
 
   // content::LocationProvider implementation.
   bool StartProvider(bool high_accuracy) override;
   void StopProvider() override;
   void GetPosition(content::Geoposition* position) override;
   void RequestRefresh() override;
   void OnPermissionGranted() override;
-
- private:
-  void NotifyCallback(const content::Geoposition& position);
-  void OnLocationResponse(const content::Geoposition& position);
   void SetUpdateCallback(
       const LocationProviderUpdateCallback& callback) override;
 
-  LocationProviderUpdateCallback callback_;
+ private:
+  // This delegate handles a subset of the LocationProvider functionality.
+  // The lifetime of the delegate relative to the BlimpLocationProvider

[Kevin M, 2016/07/19 16:01:41]

nit: I think the lifetime comment is already implied by the use of a WeakPtr, as
weak pointers are a defensive measure against this kind of uncertainty. Consider
removing the comment

[CJ, 2016/07/19 20:35:58]

Done.

+  // is unknown.
+  base::WeakPtr<Delegate> delegate_;
 
+  // Needed for GetPosition(), which returns a cached position immediately.
   content::Geoposition position_;

[Kevin M, 2016/07/19 16:01:41]

I think that we might be able to remove the comment if we called this
cached_position_.

[CJ, 2016/07/19 20:35:58]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(BlimpLocationProvider);
 };
 
 }  // namespace engine
 }  // namespace blimp
 
 #endif  // BLIMP_ENGINE_FEATURE_GEOLOCATION_BLIMP_LOCATION_PROVIDER_H_