Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: pkg/analyzer/test/generated/incremental_resolver_test.dart

Issue 2091023005: More clean-ups after removing not-body incremenal resolution. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/incremental_resolver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/incremental_resolver_test.dart
diff --git a/pkg/analyzer/test/generated/incremental_resolver_test.dart b/pkg/analyzer/test/generated/incremental_resolver_test.dart
index c1730ec4e3bfd96cffcd9318a55d487221908b09..f0b0107a7d635829c06e710542711d5afb1be201 100644
--- a/pkg/analyzer/test/generated/incremental_resolver_test.dart
+++ b/pkg/analyzer/test/generated/incremental_resolver_test.dart
@@ -154,7 +154,6 @@ class IncrementalResolverTest extends ResolverTestCase {
void setUp() {
super.setUp();
- test_resolveApiChanges = true;
logging.logger = logging.NULL_LOGGER;
}
@@ -433,8 +432,7 @@ class B {
BlockFunctionBody body = newNode.getAncestor((n) => n is BlockFunctionBody);
expect(body, isNotNull);
- bool success = resolver.resolve(body);
- expect(success, isTrue);
+ resolver.resolve(body);
_checkCacheEntries(cache);
List<AnalysisError> newErrors = analysisContext.computeErrors(source);
@@ -522,23 +520,6 @@ class PoorMansIncrementalResolutionTest extends ResolverTestCase {
CompilationUnit oldUnit;
CompilationUnitElement oldUnitElement;
- void fail_updateErrors_removeExisting_duplicateMethodDeclaration() {
- // TODO(scheglov) We fail to remove the second "foo" declaration.
- // So, we still have the same duplicate declaration problem.
- _resolveUnit(r'''
-class A {
- void foo() {}
- void foo() {}
-}
-''');
- _updateAndValidate(r'''
-class A {
- void foo() {}
- void foo2() {}
-}
-''');
- }
-
@override
void setUp() {
super.setUp();
« no previous file with comments | « pkg/analyzer/lib/src/generated/incremental_resolver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698