Issue 2091023002: Add flag to control background finalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2091023002: Add flag to control background finalization. (Closed)

Created:
4 years, 6 months ago by rmacnak

Modified:
4 years, 6 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add flag to control background finalization. It seems destructing some blink strings, TypedViewPeer, etc is not thread-safe. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/c340d0f24bff9b31af8589d9d5c0a065cdbd1a25

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -18 lines)			Patch
M	runtime/vm/dart_api_state.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flag_list.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/gc_marker.cc	View	2 chunks	+22 lines, -12 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 chunk	+11 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 6 months ago (2016-06-23 18:09:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c340d0f24bff9b31af8589d9d5c0a065cdbd1a25 (presubmit successful).