Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2090993002: Fix '[tests] Don't test moves between different reps in test-gap-resolver.cc' (Closed)

Created:
4 years, 6 months ago by balazs.kilvady
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix '[tests] Don't test moves between different reps in test-gap-resolver.cc' Port fc59eb8a7a1eb45edd2d4ff7910e66fab3093030 Original commit message: Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. This change also expands tests to include explicit FP moves (both register and stack slot). LOG=N BUG=v8:4124 BUG=chromium:622619 Committed: https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c Cr-Commit-Position: refs/heads/master@{#37241}

Patch Set 1 #

Patch Set 2 : Fix arm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -38 lines) Patch
M src/arm/assembler-arm.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/arm64/assembler-arm64.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ppc/assembler-ppc.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/s390/assembler-s390.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x87/assembler-x87.h View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 2 chunks +20 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090993002/1
4 years, 6 months ago (2016-06-23 17:32:05 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/19684)
4 years, 6 months ago (2016-06-23 17:38:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090993002/20001
4 years, 6 months ago (2016-06-23 17:52:53 UTC) #6
balazs.kilvady
4 years, 6 months ago (2016-06-23 18:10:06 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 18:50:29 UTC) #10
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-24 03:34:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090993002/20001
4 years, 6 months ago (2016-06-24 08:22:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-24 08:24:02 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 08:26:50 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c
Cr-Commit-Position: refs/heads/master@{#37241}

Powered by Google App Engine
This is Rietveld 408576698