Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/assembler-mips.cc

Issue 2090983002: Revert of Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 // ----------------------------------------------------------------------------- 218 // -----------------------------------------------------------------------------
219 // Implementation of Operand and MemOperand. 219 // Implementation of Operand and MemOperand.
220 // See assembler-mips-inl.h for inlined constructors. 220 // See assembler-mips-inl.h for inlined constructors.
221 221
222 Operand::Operand(Handle<Object> handle) { 222 Operand::Operand(Handle<Object> handle) {
223 AllowDeferredHandleDereference using_raw_address; 223 AllowDeferredHandleDereference using_raw_address;
224 rm_ = no_reg; 224 rm_ = no_reg;
225 // Verify all Objects referred by code are NOT in new space. 225 // Verify all Objects referred by code are NOT in new space.
226 Object* obj = *handle; 226 Object* obj = *handle;
227 if (obj->IsHeapObject()) { 227 if (obj->IsHeapObject()) {
228 DCHECK(!HeapObject::cast(obj)->GetHeap()->InNewSpace(obj));
228 imm32_ = reinterpret_cast<intptr_t>(handle.location()); 229 imm32_ = reinterpret_cast<intptr_t>(handle.location());
229 rmode_ = RelocInfo::EMBEDDED_OBJECT; 230 rmode_ = RelocInfo::EMBEDDED_OBJECT;
230 } else { 231 } else {
231 // No relocation needed. 232 // No relocation needed.
232 imm32_ = reinterpret_cast<intptr_t>(obj); 233 imm32_ = reinterpret_cast<intptr_t>(obj);
233 rmode_ = RelocInfo::NONE32; 234 rmode_ = RelocInfo::NONE32;
234 } 235 }
235 } 236 }
236 237
237 238
(...skipping 2938 matching lines...) Expand 10 before | Expand all | Expand 10 after
3176 3177
3177 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 3178 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
3178 Assembler::FlushICache(isolate, pc, 2 * sizeof(int32_t)); 3179 Assembler::FlushICache(isolate, pc, 2 * sizeof(int32_t));
3179 } 3180 }
3180 } 3181 }
3181 3182
3182 } // namespace internal 3183 } // namespace internal
3183 } // namespace v8 3184 } // namespace v8
3184 3185
3185 #endif // V8_TARGET_ARCH_MIPS 3186 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698