third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html - Issue 2090953006: [Blink-Workers]Set verbosity of the external exception handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html

Issue 2090953006: [Blink-Workers]Set verbosity of the external exception handler. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code changed as per the comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/workers/worker-onerror-07-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html b/third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html

index 3a4762768af6658bb95fb92872302521f62e4d59..75790b01aa645087c94c2d1e8874be32dbc9a496 100644

--- a/third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html

+++ b/third_party/WebKit/LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html

@@ -16,20 +16,20 @@

var workerOnerror, pageOnerror;

worker.onmessage = function (e) {

workerOnerror = e.data;

- shouldBeEqualToString("workerOnerror.message", "Script error.");

- shouldBeEqualToString("workerOnerror.filename", "");

- shouldEvaluateTo("workerOnerror.lineno", 0);

- shouldEvaluateTo("workerOnerror.colno", 0);

- shouldBeNull("workerOnerror.error");

+ shouldBeEqualToString("workerOnerror.message", "Uncaught This is a custom error message.");

+ shouldBeEqualToString("workerOnerror.filename", "http://localhost:8000/workers/resources/worker-importScripts-throw.js");

+ shouldEvaluateTo("workerOnerror.lineno", 1);

+ shouldEvaluateTo("workerOnerror.colno", 1);

+ shouldBeEqualToString("workerOnerror.error", "This is a custom error message.");

};

var onerrorMessage, onerrorURL, onerrorLine;

worker.onerror = function (e) {

pageOnerror = e;

- shouldBeEqualToString("pageOnerror.message", "Script error.");

- shouldBeEqualToString("pageOnerror.filename", "");

- shouldEvaluateTo("pageOnerror.lineno", 0);

- shouldEvaluateTo("pageOnerror.colno", 0);

+ shouldBeEqualToString("pageOnerror.message", "Uncaught This is a custom error message.");

+ shouldBeEqualToString("pageOnerror.filename", "http://localhost:8000/workers/resources/worker-importScripts-throw.js");

+ shouldEvaluateTo("pageOnerror.lineno", 1);

+ shouldEvaluateTo("pageOnerror.colno", 1);

shouldBeNull("pageOnerror.error");

e.preventDefault();