third_party/WebKit/LayoutTests/fast/workers/worker-onerror-05.html - Issue 2090953006: [Blink-Workers]Set verbosity of the external exception handler.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/worker-onerror-05.html

Issue 2090953006: [Blink-Workers]Set verbosity of the external exception handler. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix flaky test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/workers/worker-onerror-04-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/workers/worker-onerror-05-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 window.isOnErrorTest = true;	5 window.isOnErrorTest = true;

6 </script>	6 </script>

7 <script src="../../resources/js-test.js"></script>	7 <script src="../../resources/js-test.js"></script>

8 <script src="resources/onerror-test.js"></script>	8 <script src="resources/onerror-test.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

11 <!-- This script's body will be used to build a Blob URL to use as a Worker. -->	11 <!-- This script's body will be used to build a Blob URL to use as a Worker. -->

12 <script id="workerCode" type="text/plain">	12 <script id="workerCode" type="text/plain">

13 onerror = function(message, filename, lineno, colno, error) {	13 onerror = function(message, filename, lineno, colno, error) {

14 postMessage({	14 postMessage({

15 message: message,	15 message: message,

16 filename: filename,	16 filename: filename,

17 lineno: lineno,	17 lineno: lineno,

18 colno: colno,	18 colno: colno,

19 error: error	19 error: error

20 });	20 });

21 return false;	21 return false;
nhiroki 2016/07/25 08:30:34 After SetVerbose(true), an error handler on Worker After SetVerbose(true), an error handler on Worker context propagates an error to a handler on Window context (according to the spec[1], this would be correct behavior). This results in 2 error handler calls on Window context and 1 error handler call on Worker. This mismatches with a test expectation. Probably we should prevent the firing of Window's event handler by returning true here. [1] https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2 "If the event is not canceled, the user agent must act as if the uncaught runtime script error had occurred in the global scope that the Worker object is in, thus repeating the entire runtime script error reporting process one level up." sivag 2016/07/25 13:34:03 Done. Show quoted text On 2016/07/25 08:30:34, nhiroki (slow) wrote: > After SetVerbose(true), an error handler on Worker context propagates an error > to a handler on Window context (according to the spec[1], this would be correct > behavior). This results in 2 error handler calls on Window context and 1 error > handler call on Worker. This mismatches with a test expectation. > > Probably we should prevent the firing of Window's event handler by returning > true here. > > [1] https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2 > "If the event is not canceled, the user agent must act as if the uncaught > runtime script error had occurred in the global scope that the Worker object is > in, thus repeating the entire runtime script error reporting process one level > up." Done. nhiroki 2016/07/26 01:59:11 Hmmm... sorry, I read the spec[1] again and realiz Show quoted text On 2016/07/25 13:34:03, sivag wrote: > On 2016/07/25 08:30:34, nhiroki (slow) wrote: > > After SetVerbose(true), an error handler on Worker context propagates an error > > to a handler on Window context (according to the spec[1], this would be > correct > > behavior). This results in 2 error handler calls on Window context and 1 error > > handler call on Worker. This mismatches with a test expectation. > > > > Probably we should prevent the firing of Window's event handler by returning > > true here. > > > > [1] > https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2 > > "If the event is not canceled, the user agent must act as if the uncaught > > runtime script error had occurred in the global scope that the Worker object > is > > in, thus repeating the entire runtime script error reporting process one level > > up." > > Done. Hmmm... sorry, I read the spec[1] again and realized I misunderstood the problem and spec. I thought 'onerror' on Window context is always called regardless of whether 'onerror' on Worker context is canceled. It was not correct. 'onerror' on Window context must be called only when 'onerror' on Worker context is not canceled like the original 'worker-onerror-05.html'. Therefore, returning false here is correct...
22 }	22 }

23	23

24 foo.bar = 0;	24 foo.bar = 0;

25 </script>	25 </script>

26 <script>	26 <script>

27 description("This tests that exceptions trigger a worker's onerror in ad dition to the page-level 'worker.onerror'.");	27 description("This tests that exceptions don't trigger a worker's onerror in addition to the page-level 'worker.onerror'.");

28	28

29 checkPostMessage({	29 checkErrorEventInHandler([{

30 message: "Uncaught ReferenceError: foo is not defined",	30 message: "Uncaught ReferenceError: foo is not defined",

31 filename: "[blob: URL]",	31 filename: "[blob: URL]",

32 lineno: 13,	32 lineno: 13,

33 colno: 9,	33 colno: 9,

34 });	34 },

35	35 {

36 checkErrorEventInHandler({

37 message: "Uncaught ReferenceError: foo is not defined",	36 message: "Uncaught ReferenceError: foo is not defined",

38 filename: "[blob: URL]",	37 filename: "[blob: URL]",

39 lineno: 13,	38 lineno: 13,

40 colno: 9,	39 colno: 9,

41 });	40 }]);

42 </script>	41 </script>

43 </body>	42 </body>

44 </html>	43 </html>

45	44

OLD	NEW