third_party/WebKit/LayoutTests/fast/workers/worker-constructor.html - Issue 2090953006: [Blink-Workers]Set verbosity of the external exception handler.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/worker-constructor.html

Issue 2090953006: [Blink-Workers]Set verbosity of the external exception handler. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test worker-onerror-05 as per comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/workers/resources/onerror-test.js ('k') | third_party/WebKit/LayoutTests/fast/workers/worker-constructor-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <body>	1 <body>

2 <p>Test Worker constructor functionality. Should print a series of PASS messages , followed with DONE.</p>	2 <p>Test Worker constructor functionality. Should print a series of PASS messages , followed with DONE.</p>

3 <div id=result></div>	3 <div id=result></div>

4 <script>	4 <script>

5 function log(message)	5 function log(message)

6 {	6 {

7 document.getElementById("result").innerHTML += message + "<br>";	7 document.getElementById("result").innerHTML += message + "<br>";

8 }	8 }

9	9

10 var testCases = [	10 var testCases = [

11 "testArgumentException",	11 "testArgumentException",

12 "testRecursiveWorkerCreation",	12 "testRecursiveWorkerCreation",

13 "testNoArgument",	13 "testNoArgument",

14 "testEmptyScriptUrl",

15 "testInvalidScriptUrl",	14 "testInvalidScriptUrl",

16 "testNotExistentScriptUrl",	15 "testNotExistentScriptUrl",

	16 "testEmptyScriptUrl",
	nhiroki 2016/07/26 01:59:11 Why did you move this test case? Why did you move this test case? sivag 2016/07/27 13:20:52 In these set of tests only 2 tests throw worker.on Show quoted text On 2016/07/26 01:59:11, nhiroki wrote: > Why did you move this test case? In these set of tests only 2 tests throw worker.onerror testNotExistentScriptUrl and testEmptyScriptUrl", but here when verbose is enabled and the order of call is testEmptyScriptUrl ... testNotExistentScriptUrl in both cases testEmptyScriptUrl functions worker.onerror is getting printed.changing the order as above works fine.Initially i thought we are executing the next test case in onerror by calling runNextTest(); which might be causing this, but i tried calling this after the try catch for all test cases still the same issue exists. I am trying to figure out why this happens. sivag 2016/07/29 09:29:32 After enabling verbose the order of test is gettin Show quoted text On 2016/07/26 01:59:11, nhiroki wrote: > Why did you move this test case? After enabling verbose the order of test is getting effected. When test [1] new Worker("") gets called before test [2] new Worker("emptyscript.js") in both cases test[1] onError is getting called. If i make test [1] to new Worker("invalid.js") , with out changing the order the respective onerror functions of [1][2] get called. Any pointers, how should we proceed further here?
17 "testSuccessWorkerCreation",	17 "testSuccessWorkerCreation",

18 ];	18 ];

19 var testIndex = 0;	19 var testIndex = 0;

20	20

21 function runNextTest()	21 function runNextTest()

22 {	22 {

23 if (testIndex < testCases.length) {	23 if (testIndex < testCases.length) {

24 testIndex++;	24 testIndex++;

25 window[testCases[testIndex - 1]]();	25 window[testCases[testIndex - 1]]();

26 } else {	26 } else {

(...skipping 102 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
129	129

130 if (window.testRunner) {	130 if (window.testRunner) {

131 testRunner.dumpAsText();	131 testRunner.dumpAsText();

132 testRunner.waitUntilDone();	132 testRunner.waitUntilDone();

133 }	133 }

134	134

135 runNextTest();	135 runNextTest();

136	136

137 </script>	137 </script>

138 </body>	138 </body>

OLD	NEW