Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2090953004: Reland of Move memory-infra check from background tracing and whitelist memory dump args (Closed)

Created:
4 years, 6 months ago by ssid
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@enabled_modes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Move memory-infra check from background tracing and whitelist memory dump args (patchset #1 id:1 of https://codereview.chromium.org/2095593003/ ) Reason for reland: Changing the category to use const char* string "memory-infra" instead of the static member kTraceCategory, to avoid static initialization. Original issue's description: > Revert of Move memory-infra check from background tracing and whitelist memory dump args (patchset #1 id:20001 of https://codereview.chromium.org/2092463002/ ) > > Reason for revert: > Speculative revert. Looks like this could have broken mac and linux sizes: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21314 > > Original issue's description: > > Move memory-infra check from background tracing and whitelist memory dump args > > > > BUG=613198 > > > > Committed: https://crrev.com/7d2fd66cc632f2fcf5fb821936cdac319f7f8233 > > Cr-Commit-Position: refs/heads/master@{#401652} > > TBR=primiano@chromium.org,oysteine@chromium.org,ssid@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=613198 > > Committed: https://crrev.com/a8b0d1386ef9ae3f3f45316c0e5bd4d39a8e5a22 > Cr-Commit-Position: refs/heads/master@{#401725} TBR=primiano@chromium.org,oysteine@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true BUG=613198 Committed: https://crrev.com/111f2d475c3e7a0bf621439bc48f7aac22acb16a Cr-Commit-Position: refs/heads/master@{#401790}

Patch Set 1 : Original CL #

Patch Set 2 : Fix. #

Patch Set 3 : Add comment. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/trace_event_args_whitelist.cc View 1 2 2 chunks +5 lines, -0 lines 1 comment Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
ssid
Created Reland of Move memory-infra check from background tracing and whitelist memory dump args
4 years, 6 months ago (2016-06-23 21:35:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090953004/100001
4 years, 6 months ago (2016-06-23 21:40:39 UTC) #4
Dmitry Skiba
lgtm
4 years, 6 months ago (2016-06-23 22:25:34 UTC) #8
Primiano Tucci (use gerrit)
https://codereview.chromium.org/2090953004/diff/120001/chrome/common/trace_event_args_whitelist.cc File chrome/common/trace_event_args_whitelist.cc (right): https://codereview.chromium.org/2090953004/diff/120001/chrome/common/trace_event_args_whitelist.cc#newcode30 chrome/common/trace_event_args_whitelist.cc:30: // static initialization of this struct. ^__^ Wow. Definitely ...
4 years, 6 months ago (2016-06-23 22:41:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090953004/120001
4 years, 6 months ago (2016-06-23 23:12:11 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:120001)
4 years, 6 months ago (2016-06-24 02:13:06 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 02:16:01 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/111f2d475c3e7a0bf621439bc48f7aac22acb16a
Cr-Commit-Position: refs/heads/master@{#401790}

Powered by Google App Engine
This is Rietveld 408576698