Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2090913002: Add strings and notifier ID for low disk. (Closed)

Created:
4 years, 6 months ago by dspaid
Modified:
4 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add strings and notifier ID for low disk. Actual notifications using these strings will be added in a followup CL. BUG=622590 Committed: https://crrev.com/3ab0d85b5bea7fca2637d10e7ccc1fa8cb0e3a94 Cr-Commit-Position: refs/heads/master@{#401825}

Patch Set 1 #

Patch Set 2 : revert unrelated formatting #

Patch Set 3 : Add strings and notifier ID for low disk. #

Total comments: 6

Patch Set 4 : Update strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M ash/common/system/system_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/system_notifier.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
dspaid
4 years, 6 months ago (2016-06-24 00:50:40 UTC) #3
Mr4D (OOO till 08-26)
lgtm
4 years, 6 months ago (2016-06-24 01:35:03 UTC) #4
Mr4D (OOO till 08-26)
sorry a few more nits... https://codereview.chromium.org/2090913002/diff/40001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2090913002/diff/40001/chrome/app/chromeos_strings.grdp#newcode6732 chrome/app/chromeos_strings.grdp:6732: Device is low on ...
4 years, 6 months ago (2016-06-24 01:36:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090913002/40001
4 years, 6 months ago (2016-06-24 01:36:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/182598) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-24 01:44:41 UTC) #9
dspaid
https://codereview.chromium.org/2090913002/diff/40001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2090913002/diff/40001/chrome/app/chromeos_strings.grdp#newcode6732 chrome/app/chromeos_strings.grdp:6732: Device is low on space On 2016/06/24 01:36:21, Mr4D ...
4 years, 6 months ago (2016-06-24 02:32:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090913002/60001
4 years, 6 months ago (2016-06-24 06:02:21 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-24 06:09:05 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 06:10:40 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3ab0d85b5bea7fca2637d10e7ccc1fa8cb0e3a94
Cr-Commit-Position: refs/heads/master@{#401825}

Powered by Google App Engine
This is Rietveld 408576698