Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2090903003: Add use counters for the passive option to addEventListener (Closed)

Created:
4 years, 6 months ago by Rick Byers
Modified:
4 years, 6 months ago
Reviewers:
dtapuska, rkaplow
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counters for the passive option to addEventListener We've long tracked the primary metric - how often do scrolls block unnecessarily (via the Event.PassiveListeners histogram) but the results are complex. To help interpret the results let's also just count how common it is for a page to use the 'passive' option anywhere. This isn't directly meaningful by itself in terms of outcomes, but is still useful as a rough indication of developer adoption for the API. BUG=489802 TBR=rkaplow Committed: https://crrev.com/e95fc1fa03174e0064d73638d9e6ad364ecdb514 Cr-Commit-Position: refs/heads/master@{#401703}

Patch Set 1 #

Patch Set 2 : Update histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Rick Byers
dtapuska@ PTAL +rkaplow for histograms.xml OWNERS
4 years, 6 months ago (2016-06-23 18:27:24 UTC) #3
dtapuska
On 2016/06/23 18:27:24, Rick Byers wrote: > dtapuska@ PTAL > > +rkaplow for histograms.xml OWNERS ...
4 years, 6 months ago (2016-06-23 18:30:20 UTC) #4
Rick Byers
On 2016/06/23 18:30:20, dtapuska wrote: > On 2016/06/23 18:27:24, Rick Byers wrote: > > dtapuska@ ...
4 years, 6 months ago (2016-06-23 20:09:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090903003/20001
4 years, 6 months ago (2016-06-23 20:10:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 20:24:59 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 20:26:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e95fc1fa03174e0064d73638d9e6ad364ecdb514
Cr-Commit-Position: refs/heads/master@{#401703}

Powered by Google App Engine
This is Rietveld 408576698