Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: android_webview/browser/hardware_renderer.cc

Issue 2090903002: aw: Share cc::Display instance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: works Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/hardware_renderer.h" 5 #include "android_webview/browser/hardware_renderer.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/aw_gl_surface.h" 9 #include "android_webview/browser/aw_gl_surface.h"
10 #include "android_webview/browser/aw_render_thread_context_provider.h" 10 #include "android_webview/browser/aw_render_thread_context_provider.h"
11 #include "android_webview/browser/child_frame.h" 11 #include "android_webview/browser/child_frame.h"
12 #include "android_webview/browser/deferred_gpu_command_service.h" 12 #include "android_webview/browser/deferred_gpu_command_service.h"
13 #include "android_webview/browser/parent_compositor_draw_constraints.h" 13 #include "android_webview/browser/parent_compositor_draw_constraints.h"
14 #include "android_webview/browser/parent_output_surface.h" 14 #include "android_webview/browser/parent_output_surface.h"
15 #include "android_webview/browser/render_thread_manager.h" 15 #include "android_webview/browser/render_thread_manager.h"
16 #include "android_webview/browser/surfaces_instance.h"
16 #include "android_webview/public/browser/draw_gl.h" 17 #include "android_webview/public/browser/draw_gl.h"
17 #include "base/auto_reset.h" 18 #include "base/auto_reset.h"
18 #include "base/strings/string_number_conversions.h" 19 #include "base/strings/string_number_conversions.h"
19 #include "base/trace_event/trace_event.h" 20 #include "base/trace_event/trace_event.h"
20 #include "cc/output/compositor_frame.h" 21 #include "cc/output/compositor_frame.h"
21 #include "cc/output/output_surface.h" 22 #include "cc/output/output_surface.h"
22 #include "cc/output/renderer_settings.h" 23 #include "cc/output/renderer_settings.h"
23 #include "cc/output/texture_mailbox_deleter.h" 24 #include "cc/output/texture_mailbox_deleter.h"
24 #include "cc/quads/shared_quad_state.h" 25 #include "cc/quads/shared_quad_state.h"
25 #include "cc/quads/surface_draw_quad.h"
26 #include "cc/scheduler/begin_frame_source.h" 26 #include "cc/scheduler/begin_frame_source.h"
27 #include "cc/surfaces/display.h" 27 #include "cc/surfaces/display.h"
28 #include "cc/surfaces/display_scheduler.h" 28 #include "cc/surfaces/display_scheduler.h"
29 #include "cc/surfaces/surface_factory.h" 29 #include "cc/surfaces/surface_factory.h"
30 #include "cc/surfaces/surface_id_allocator.h" 30 #include "cc/surfaces/surface_id_allocator.h"
31 #include "gpu/command_buffer/client/gl_in_process_context.h" 31 #include "gpu/command_buffer/client/gl_in_process_context.h"
32 #include "gpu/command_buffer/common/gles2_cmd_utils.h" 32 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
33 #include "ui/gfx/geometry/rect_conversions.h" 33 #include "ui/gfx/geometry/rect_conversions.h"
34 #include "ui/gfx/geometry/rect_f.h" 34 #include "ui/gfx/geometry/rect_f.h"
35 #include "ui/gfx/transform.h" 35 #include "ui/gfx/transform.h"
36 #include "ui/gl/gl_bindings.h" 36 #include "ui/gl/gl_bindings.h"
37 37
38 namespace android_webview { 38 namespace android_webview {
39 39
40 HardwareRenderer::HardwareRenderer(RenderThreadManager* state) 40 HardwareRenderer::HardwareRenderer(RenderThreadManager* state)
41 : render_thread_manager_(state), 41 : render_thread_manager_(state),
42 last_egl_context_(eglGetCurrentContext()), 42 last_egl_context_(eglGetCurrentContext()),
43 gl_surface_(new AwGLSurface), 43 surfaces_(SurfacesInstance::GetOrCreateInstance()),
44 last_committed_output_surface_id_(0u), 44 last_committed_output_surface_id_(0u),
45 last_submitted_output_surface_id_(0u), 45 last_submitted_output_surface_id_(0u) {
46 output_surface_(NULL) {
47 DCHECK(last_egl_context_); 46 DCHECK(last_egl_context_);
48 47
49 cc::RendererSettings settings; 48 surface_id_allocator_ = surfaces_->CreateSurfaceIdAllocator();
50 49 surfaces_->GetSurfaceManager()->RegisterSurfaceFactoryClient(
51 // Should be kept in sync with compositor_impl_android.cc.
52 settings.allow_antialiasing = false;
53 settings.highp_threshold_min = 2048;
54
55 // Webview does not own the surface so should not clear it.
56 settings.should_clear_root_render_pass = false;
57
58 surface_manager_.reset(new cc::SurfaceManager);
59 surface_id_allocator_.reset(new cc::SurfaceIdAllocator(1));
60 surface_id_allocator_->RegisterSurfaceIdNamespace(surface_manager_.get());
61 surface_manager_->RegisterSurfaceFactoryClient(
62 surface_id_allocator_->id_namespace(), this); 50 surface_id_allocator_->id_namespace(), this);
63
64 std::unique_ptr<cc::BeginFrameSource> begin_frame_source(
65 new cc::StubBeginFrameSource);
66 std::unique_ptr<cc::TextureMailboxDeleter> texture_mailbox_deleter(
67 new cc::TextureMailboxDeleter(nullptr));
68 std::unique_ptr<ParentOutputSurface> output_surface_holder(
69 new ParentOutputSurface(AwRenderThreadContextProvider::Create(
70 gl_surface_, DeferredGpuCommandService::GetInstance())));
71 output_surface_ = output_surface_holder.get();
72 std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(
73 begin_frame_source.get(), nullptr,
74 output_surface_holder->capabilities().max_frames_pending));
75 display_.reset(new cc::Display(
76 surface_manager_.get(), nullptr /* shared_bitmap_manager */,
77 nullptr /* gpu_memory_buffer_manager */, settings,
78 surface_id_allocator_->id_namespace(), std::move(begin_frame_source),
79 std::move(output_surface_holder), std::move(scheduler),
80 std::move(texture_mailbox_deleter)));
81 display_->Initialize(this);
82 } 51 }
83 52
84 HardwareRenderer::~HardwareRenderer() { 53 HardwareRenderer::~HardwareRenderer() {
85 // Must reset everything before |surface_factory_| to ensure all 54 // Must reset everything before |surface_factory_| to ensure all
86 // resources are returned before resetting. 55 // resources are returned before resetting.
87 if (!root_id_.is_null())
88 surface_factory_->Destroy(root_id_);
89 if (!child_id_.is_null()) 56 if (!child_id_.is_null())
90 surface_factory_->Destroy(child_id_); 57 surface_factory_->Destroy(child_id_);
91 display_.reset();
92 surface_factory_.reset(); 58 surface_factory_.reset();
93 surface_manager_->UnregisterSurfaceFactoryClient( 59 surfaces_->GetSurfaceManager()->UnregisterSurfaceFactoryClient(
94 surface_id_allocator_->id_namespace()); 60 surface_id_allocator_->id_namespace());
95 61
96 // Reset draw constraints. 62 // Reset draw constraints.
97 render_thread_manager_->PostExternalDrawConstraintsToChildCompositorOnRT( 63 render_thread_manager_->PostExternalDrawConstraintsToChildCompositorOnRT(
98 ParentCompositorDrawConstraints()); 64 ParentCompositorDrawConstraints());
99 ReturnResourcesInChildFrame(); 65 ReturnResourcesInChildFrame();
100 } 66 }
101 67
102 void HardwareRenderer::CommitFrame() { 68 void HardwareRenderer::CommitFrame() {
103 TRACE_EVENT0("android_webview", "CommitFrame"); 69 TRACE_EVENT0("android_webview", "CommitFrame");
(...skipping 23 matching lines...) Expand all
127 if (last_egl_context_ != current_context) 93 if (last_egl_context_ != current_context)
128 DLOG(WARNING) << "EGLContextChanged"; 94 DLOG(WARNING) << "EGLContextChanged";
129 95
130 // SurfaceFactory::SubmitCompositorFrame might call glFlush. So calling it 96 // SurfaceFactory::SubmitCompositorFrame might call glFlush. So calling it
131 // during "kModeSync" stage (which does not allow GL) might result in extra 97 // during "kModeSync" stage (which does not allow GL) might result in extra
132 // kModeProcess. Instead, submit the frame in "kModeDraw" stage to avoid 98 // kModeProcess. Instead, submit the frame in "kModeDraw" stage to avoid
133 // unnecessary kModeProcess. 99 // unnecessary kModeProcess.
134 if (child_frame_.get() && child_frame_->frame.get()) { 100 if (child_frame_.get() && child_frame_->frame.get()) {
135 if (!compositor_id_.Equals(child_frame_->compositor_id) || 101 if (!compositor_id_.Equals(child_frame_->compositor_id) ||
136 last_submitted_output_surface_id_ != child_frame_->output_surface_id) { 102 last_submitted_output_surface_id_ != child_frame_->output_surface_id) {
137 if (!root_id_.is_null())
138 surface_factory_->Destroy(root_id_);
139 if (!child_id_.is_null()) 103 if (!child_id_.is_null())
140 surface_factory_->Destroy(child_id_); 104 surface_factory_->Destroy(child_id_);
141 105
142 root_id_ = cc::SurfaceId();
143 child_id_ = cc::SurfaceId(); 106 child_id_ = cc::SurfaceId();
144 107
145 // This will return all the resources to the previous compositor. 108 // This will return all the resources to the previous compositor.
146 surface_factory_.reset(); 109 surface_factory_.reset();
147 compositor_id_ = child_frame_->compositor_id; 110 compositor_id_ = child_frame_->compositor_id;
148 last_submitted_output_surface_id_ = child_frame_->output_surface_id; 111 last_submitted_output_surface_id_ = child_frame_->output_surface_id;
149 surface_factory_.reset( 112 surface_factory_.reset(
150 new cc::SurfaceFactory(surface_manager_.get(), this)); 113 new cc::SurfaceFactory(surfaces_->GetSurfaceManager(), this));
151 } 114 }
152 115
153 std::unique_ptr<cc::CompositorFrame> child_compositor_frame = 116 std::unique_ptr<cc::CompositorFrame> child_compositor_frame =
154 std::move(child_frame_->frame); 117 std::move(child_frame_->frame);
155 118
156 // On Android we put our browser layers in physical pixels and set our 119 // On Android we put our browser layers in physical pixels and set our
157 // browser CC device_scale_factor to 1, so suppress the transform between 120 // browser CC device_scale_factor to 1, so suppress the transform between
158 // DIP and pixels. 121 // DIP and pixels.
159 child_compositor_frame->delegated_frame_data->device_scale_factor = 1.0f; 122 child_compositor_frame->delegated_frame_data->device_scale_factor = 1.0f;
160 123
(...skipping 29 matching lines...) Expand all
190 draw_constraints); 153 draw_constraints);
191 } 154 }
192 155
193 if (child_id_.is_null()) 156 if (child_id_.is_null())
194 return; 157 return;
195 158
196 gfx::Rect clip(draw_info->clip_left, draw_info->clip_top, 159 gfx::Rect clip(draw_info->clip_left, draw_info->clip_top,
197 draw_info->clip_right - draw_info->clip_left, 160 draw_info->clip_right - draw_info->clip_left,
198 draw_info->clip_bottom - draw_info->clip_top); 161 draw_info->clip_bottom - draw_info->clip_top);
199 162
163 /*
200 // Create a frame with a single SurfaceDrawQuad referencing the child 164 // Create a frame with a single SurfaceDrawQuad referencing the child
201 // Surface and transformed using the given transform. 165 // Surface and transformed using the given transform.
202 std::unique_ptr<cc::RenderPass> render_pass = cc::RenderPass::Create(); 166 std::unique_ptr<cc::RenderPass> render_pass = cc::RenderPass::Create();
203 render_pass->SetAll(cc::RenderPassId(1, 1), gfx::Rect(viewport), clip, 167 render_pass->SetAll(cc::RenderPassId(1, 1), gfx::Rect(viewport), clip,
204 gfx::Transform(), false); 168 gfx::Transform(), false);
205 169
206 cc::SharedQuadState* quad_state = 170 cc::SharedQuadState* quad_state =
207 render_pass->CreateAndAppendSharedQuadState(); 171 render_pass->CreateAndAppendSharedQuadState();
208 quad_state->quad_to_target_transform = transform; 172 quad_state->quad_to_target_transform = transform;
209 quad_state->quad_layer_bounds = frame_size_; 173 quad_state->quad_layer_bounds = frame_size_;
210 quad_state->visible_quad_layer_rect = gfx::Rect(frame_size_); 174 quad_state->visible_quad_layer_rect = gfx::Rect(frame_size_);
211 quad_state->opacity = 1.f; 175 quad_state->opacity = 1.f;
212 176
213 cc::SurfaceDrawQuad* surface_quad = 177 cc::SurfaceDrawQuad* surface_quad =
214 render_pass->CreateAndAppendDrawQuad<cc::SurfaceDrawQuad>(); 178 render_pass->CreateAndAppendDrawQuad<cc::SurfaceDrawQuad>();
215 surface_quad->SetNew(quad_state, gfx::Rect(quad_state->quad_layer_bounds), 179 surface_quad->SetNew(quad_state, gfx::Rect(quad_state->quad_layer_bounds),
216 gfx::Rect(quad_state->quad_layer_bounds), child_id_); 180 gfx::Rect(quad_state->quad_layer_bounds), child_id_);
217 181
218 std::unique_ptr<cc::DelegatedFrameData> delegated_frame( 182 std::unique_ptr<cc::DelegatedFrameData> delegated_frame(
219 new cc::DelegatedFrameData); 183 new cc::DelegatedFrameData);
220 delegated_frame->render_pass_list.push_back(std::move(render_pass)); 184 delegated_frame->render_pass_list.push_back(std::move(render_pass));
221 std::unique_ptr<cc::CompositorFrame> frame(new cc::CompositorFrame); 185 std::unique_ptr<cc::CompositorFrame> frame(new cc::CompositorFrame);
222 frame->delegated_frame_data = std::move(delegated_frame); 186 frame->delegated_frame_data = std::move(delegated_frame);
223 187
188 cc::Display* display = surfaces_->GetDisplay();
224 if (root_id_.is_null()) { 189 if (root_id_.is_null()) {
225 root_id_ = surface_id_allocator_->GenerateId(); 190 root_id_ = surface_id_allocator_->GenerateId();
226 surface_factory_->Create(root_id_); 191 surface_factory_->Create(root_id_);
227 display_->SetSurfaceId(root_id_, 1.f); 192 display->SetSurfaceId(root_id_, 1.f);
228 } 193 }
229 surface_factory_->SubmitCompositorFrame(root_id_, std::move(frame), 194 surface_factory_->SubmitCompositorFrame(root_id_, std::move(frame),
230 cc::SurfaceFactory::DrawCallback()); 195 cc::SurfaceFactory::DrawCallback());
231 196
232 display_->Resize(viewport); 197 display->Resize(viewport);
233 198
234 output_surface_->SetGLState(gl_state); 199 surfaces_->GetOutputSurface()->SetGLState(gl_state);
235 display_->SetExternalClip(clip); 200 display->SetExternalClip(clip);
236 display_->DrawAndSwap(); 201 display->DrawAndSwap();
202 */
203 surfaces_->DrawAndSwap(viewport, clip, transform, frame_size_, child_id_,
204 gl_state);
237 } 205 }
238 206
239 void HardwareRenderer::ReturnResources( 207 void HardwareRenderer::ReturnResources(
240 const cc::ReturnedResourceArray& resources) { 208 const cc::ReturnedResourceArray& resources) {
241 ReturnResourcesToCompositor(resources, compositor_id_, 209 ReturnResourcesToCompositor(resources, compositor_id_,
242 last_submitted_output_surface_id_); 210 last_submitted_output_surface_id_);
243 } 211 }
244 212
245 void HardwareRenderer::SetBeginFrameSource( 213 void HardwareRenderer::SetBeginFrameSource(
246 cc::BeginFrameSource* begin_frame_source) { 214 cc::BeginFrameSource* begin_frame_source) {
247 // TODO(tansell): Hook this up. 215 // TODO(tansell): Hook this up.
248 } 216 }
249 217
250 void HardwareRenderer::SetBackingFrameBufferObject( 218 void HardwareRenderer::SetBackingFrameBufferObject(
251 int framebuffer_binding_ext) { 219 int framebuffer_binding_ext) {
252 gl_surface_->SetBackingFrameBufferObject(framebuffer_binding_ext); 220 surfaces_->SetBackingFrameBufferObject(framebuffer_binding_ext);
253 } 221 }
254 222
255 void HardwareRenderer::ReturnResourcesInChildFrame() { 223 void HardwareRenderer::ReturnResourcesInChildFrame() {
256 if (child_frame_.get() && child_frame_->frame.get()) { 224 if (child_frame_.get() && child_frame_->frame.get()) {
257 cc::ReturnedResourceArray resources_to_return; 225 cc::ReturnedResourceArray resources_to_return;
258 cc::TransferableResource::ReturnResources( 226 cc::TransferableResource::ReturnResources(
259 child_frame_->frame->delegated_frame_data->resource_list, 227 child_frame_->frame->delegated_frame_data->resource_list,
260 &resources_to_return); 228 &resources_to_return);
261 229
262 // The child frame's compositor id is not necessarily same as 230 // The child frame's compositor id is not necessarily same as
263 // compositor_id_. 231 // compositor_id_.
264 ReturnResourcesToCompositor(resources_to_return, 232 ReturnResourcesToCompositor(resources_to_return,
265 child_frame_->compositor_id, 233 child_frame_->compositor_id,
266 child_frame_->output_surface_id); 234 child_frame_->output_surface_id);
267 } 235 }
268 child_frame_.reset(); 236 child_frame_.reset();
269 } 237 }
270 238
271 void HardwareRenderer::ReturnResourcesToCompositor( 239 void HardwareRenderer::ReturnResourcesToCompositor(
272 const cc::ReturnedResourceArray& resources, 240 const cc::ReturnedResourceArray& resources,
273 const CompositorID& compositor_id, 241 const CompositorID& compositor_id,
274 uint32_t output_surface_id) { 242 uint32_t output_surface_id) {
275 if (output_surface_id != last_committed_output_surface_id_) 243 if (output_surface_id != last_committed_output_surface_id_)
276 return; 244 return;
277 render_thread_manager_->InsertReturnedResourcesOnRT(resources, compositor_id, 245 render_thread_manager_->InsertReturnedResourcesOnRT(resources, compositor_id,
278 output_surface_id); 246 output_surface_id);
279 } 247 }
280 248
281 } // namespace android_webview 249 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698