Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 20909002: Correct the flag: is_extension_upgrade, which denote whether the extension is being upgrading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Shouldn't break CheckPermissionsIncrease. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 747 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 void FinishInstallation(const extensions::Extension* extension); 758 void FinishInstallation(const extensions::Extension* extension);
759 759
760 // Updates the |extension|'s active permission set to include only permissions 760 // Updates the |extension|'s active permission set to include only permissions
761 // currently requested by the extension and all the permissions required by 761 // currently requested by the extension and all the permissions required by
762 // the extension. 762 // the extension.
763 void UpdateActivePermissions(const extensions::Extension* extension); 763 void UpdateActivePermissions(const extensions::Extension* extension);
764 764
765 // Disables the extension if the privilege level has increased 765 // Disables the extension if the privilege level has increased
766 // (e.g., due to an upgrade). 766 // (e.g., due to an upgrade).
767 void CheckPermissionsIncrease(const extensions::Extension* extension, 767 void CheckPermissionsIncrease(const extensions::Extension* extension,
768 bool is_upgrade); 768 bool is_extension_installed);
769 769
770 // Helper that updates the active extension list used for crash reporting. 770 // Helper that updates the active extension list used for crash reporting.
771 void UpdateActiveExtensionsInCrashReporter(); 771 void UpdateActiveExtensionsInCrashReporter();
772 772
773 // Helper to inspect an ExtensionHost after it has been loaded. 773 // Helper to inspect an ExtensionHost after it has been loaded.
774 void InspectExtensionHost(extensions::ExtensionHost* host); 774 void InspectExtensionHost(extensions::ExtensionHost* host);
775 775
776 // Helper to determine whether we should initially enable an installed 776 // Helper to determine whether we should initially enable an installed
777 // (or upgraded) extension. 777 // (or upgraded) extension.
778 bool ShouldEnableOnInstall(const extensions::Extension* extension); 778 bool ShouldEnableOnInstall(const extensions::Extension* extension);
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
957 syncer::SyncableService::StartSyncFlare flare_; 957 syncer::SyncableService::StartSyncFlare flare_;
958 958
959 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 959 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
960 InstallAppsWithUnlimtedStorage); 960 InstallAppsWithUnlimtedStorage);
961 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 961 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
962 InstallAppsAndCheckStorageProtection); 962 InstallAppsAndCheckStorageProtection);
963 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 963 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
964 }; 964 };
965 965
966 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 966 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698