Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2090893002:
[tools/perf] Do not set skip_waits for story in benchmark (Closed)
Description[tools/perf] Do not set skip_waits for story in benchmark
In the past, we used this to get the cycle time of telemetry_perf_unittest
down to address the slow CQ code yellow. However, now all
telemetry_perf_unittest is swarmed & sharded, this is no longer
necessary and can affect correctness of the benchmark smoke test (see https://codereview.chromium.org/2081403003/)
BUG=548652
Committed: https://crrev.com/514acafdae206be9939f27f28c126904c3fab27d
Cr-Commit-Position: refs/heads/master@{#401627}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== [tools/perf] Do not set skip_waits for story in benchmark BUG=548652 ========== to ========== [tools/perf] Do not set skip_waits for story in benchmark BUG=548652 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [tools/perf] Do not set skip_waits for story in benchmark BUG=548652 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [tools/perf] Do not set skip_waits for story in benchmark BUG=548652 ==========
nednguyen@google.com changed reviewers: + sullivan@chromium.org
Description was changed from ========== [tools/perf] Do not set skip_waits for story in benchmark BUG=548652 ========== to ========== [tools/perf] Do not set skip_waits for story in benchmark In the past, we used this to get the cycle time of telemetry_perf_unittest down to address the slow CQ code yellow. However, now all telemetry_perf_unittest is swarmed & sharded, this is no longer necessary and can affect correctness of the benchmark smoke test. BUG=548652 ==========
nednguyen@google.com changed reviewers: + dtu@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090893002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [tools/perf] Do not set skip_waits for story in benchmark In the past, we used this to get the cycle time of telemetry_perf_unittest down to address the slow CQ code yellow. However, now all telemetry_perf_unittest is swarmed & sharded, this is no longer necessary and can affect correctness of the benchmark smoke test. BUG=548652 ========== to ========== [tools/perf] Do not set skip_waits for story in benchmark In the past, we used this to get the cycle time of telemetry_perf_unittest down to address the slow CQ code yellow. However, now all telemetry_perf_unittest is swarmed & sharded, this is no longer necessary and can affect correctness of the benchmark smoke test (see https://codereview.chromium.org/2081403003/) BUG=548652 ==========
On 2016/06/23 05:22:21, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. PTAL This is blocking enabling smoke coverage for all telemetry benchmarks on desktop in https://codereview.chromium.org/2081403003/
lgtm
The CQ bit was checked by nednguyen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090893002/1
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Do not set skip_waits for story in benchmark In the past, we used this to get the cycle time of telemetry_perf_unittest down to address the slow CQ code yellow. However, now all telemetry_perf_unittest is swarmed & sharded, this is no longer necessary and can affect correctness of the benchmark smoke test (see https://codereview.chromium.org/2081403003/) BUG=548652 ========== to ========== [tools/perf] Do not set skip_waits for story in benchmark In the past, we used this to get the cycle time of telemetry_perf_unittest down to address the slow CQ code yellow. However, now all telemetry_perf_unittest is swarmed & sharded, this is no longer necessary and can affect correctness of the benchmark smoke test (see https://codereview.chromium.org/2081403003/) BUG=548652 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Do not set skip_waits for story in benchmark In the past, we used this to get the cycle time of telemetry_perf_unittest down to address the slow CQ code yellow. However, now all telemetry_perf_unittest is swarmed & sharded, this is no longer necessary and can affect correctness of the benchmark smoke test (see https://codereview.chromium.org/2081403003/) BUG=548652 ========== to ========== [tools/perf] Do not set skip_waits for story in benchmark In the past, we used this to get the cycle time of telemetry_perf_unittest down to address the slow CQ code yellow. However, now all telemetry_perf_unittest is swarmed & sharded, this is no longer necessary and can affect correctness of the benchmark smoke test (see https://codereview.chromium.org/2081403003/) BUG=548652 Committed: https://crrev.com/514acafdae206be9939f27f28c126904c3fab27d Cr-Commit-Position: refs/heads/master@{#401627} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/514acafdae206be9939f27f28c126904c3fab27d Cr-Commit-Position: refs/heads/master@{#401627} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
