Fix an issue that pdf is not auto-opened after typing url in omnibox

Fix an issue that pdf is not auto-opened after typing url in omnibox

If a pdf download is triggered from omnibox, we don't auto-open the
file.
This is because the download item doesn't carry the user gesture flag.
However, in most cases the url is typed or the navigation is triggerd by
user.
This CL fixes the issue by identifying these downloads that are initiated
by user.

BUG=622378
Committed: https://crrev.com/a06924c6c0170d0007966d0d86a3070a6ca0e717
Cr-Commit-Position: refs/heads/master@{#401672}

[qinmin, 2016-06-22 23:52:15]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-06-22 23:52:15]

PTAL

[Ted C, 2016-06-22 23:58:03]

lgtm

https://codereview.chromium.org/2090853002/diff/1/chrome/browser/android/down...
File chrome/browser/android/download/download_controller.cc (right):

https://codereview.chromium.org/2090853002/diff/1/chrome/browser/android/down...
chrome/browser/android/download/download_controller.cc:330: base_transition ==
ui::PAGE_TRANSITION_TYPED ||
could we use !PageTransitionIsWebTriggerable here instead?

[qinmin, 2016-06-23 18:20:11]

https://codereview.chromium.org/2090853002/diff/1/chrome/browser/android/down...
File chrome/browser/android/download/download_controller.cc (right):

https://codereview.chromium.org/2090853002/diff/1/chrome/browser/android/down...
chrome/browser/android/download/download_controller.cc:330: base_transition ==
ui::PAGE_TRANSITION_TYPED ||
On 2016/06/22 23:58:03, Ted C wrote:
> could we use !PageTransitionIsWebTriggerable here instead?

!PageTransitionIsWebTriggerable could be too broad. For example, if
base_transition is an invalid value, then !PageTransitionIsWebTriggerable will
return true.

[qinmin, 2016-06-23 18:20:25]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-06-23 18:21:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090853002/1

[commit-bot: I haz the power, 2016-06-23 19:08:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-23 19:11:10]

Description was changed from

==========
Fix an issue that pdf is not auto-opened after typing url in omnibox

If a pdf download is triggered from omnibox, we don't auto-open the
file.
This is because the download item doesn't carry the user gesture flag.
However, in most cases the url is typed or the navigation is triggerd by
user.
This CL fixes the issue by identifying these downloads that are initiated
by user.

BUG=622378
==========

to

==========
Fix an issue that pdf is not auto-opened after typing url in omnibox

If a pdf download is triggered from omnibox, we don't auto-open the
file.
This is because the download item doesn't carry the user gesture flag.
However, in most cases the url is typed or the navigation is triggerd by
user.
This CL fixes the issue by identifying these downloads that are initiated
by user.

BUG=622378

Committed: https://crrev.com/a06924c6c0170d0007966d0d86a3070a6ca0e717
Cr-Commit-Position: refs/heads/master@{#401672}
==========

[commit-bot: I haz the power, 2016-06-23 19:11:11]

Patchset 1 (id:??) landed as
https://crrev.com/a06924c6c0170d0007966d0d86a3070a6ca0e717
Cr-Commit-Position: refs/heads/master@{#401672}