Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 209083003: Remove unnecessary ifdefs from font code (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Remove unnecessary ifdefs from font code Remove unnecessary precompiler conditional statements from the font platform code that always evaluate to true or are no longer needed. R=dglazkov@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M Source/platform/fonts/FontCustomPlatformData.h View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/fonts/skia/SimpleFontDataSkia.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
eae
6 years, 9 months ago (2014-03-21 22:19:10 UTC) #1
dglazkov
rslgtm
6 years, 9 months ago (2014-03-21 22:41:41 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-21 22:46:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209083003/1
6 years, 9 months ago (2014-03-21 22:46:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 22:51:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-21 22:51:11 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-21 22:52:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209083003/1
6 years, 9 months ago (2014-03-21 22:52:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 23:23:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-21 23:23:19 UTC) #10
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-22 00:07:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209083003/1
6 years, 9 months ago (2014-03-22 00:07:04 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 01:09:21 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-22 01:09:22 UTC) #14
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-22 01:13:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209083003/1
6 years, 9 months ago (2014-03-22 01:13:29 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 04:31:00 UTC) #17
Message was sent while issue was closed. 
Change committed as 169785

Powered by Google App Engine
This is Rietveld 408576698