cc: Fix property tree animation sync bug

cc/trees/layer_tree_host_unittest_animation.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host.h"
 
 #include <stdint.h>
 
 #include "cc/animation/animation_curve.h"
 #include "cc/animation/animation_host.h"
@@ skipping 1627 matching lines @@
  private:
   bool called_animation_started_;
   bool called_animation_finished_;
   FakeContentLayerClient client_;
   scoped_refptr<FakePictureLayer> picture_;
 };
 
 SINGLE_AND_MULTI_THREAD_TEST_F(
     LayerTreeHostAnimationTestNotifyAnimationFinished);
 
+// Check that transform sync happens correctly at commit when we remove and add
+// a different animation player to an element.
+class LayerTreeHostAnimationTestChangeAnimationPlayer
+    : public LayerTreeHostAnimationTest {
+ public:
+  void SetupTree() override {
+    LayerTreeHostAnimationTest::SetupTree();
+    AttachPlayersToTimeline();
+    timeline_->DetachPlayer(player_child_.get());
+    player_->AttachElement(layer_tree_host()->root_layer()->id());
+    AddAnimatedTransformToPlayer(player_.get(), 1.0, 5, 5);

[ajuma, 2016/06/24 21:02:34]

If you use the version of AddAnimatedTransformToPlayer that takes
start_operations and end_operations, you can set them both to the same
transform, and then you can check for equality to that transform instead of
checking for inequality in CommitCompleteOnThread.

[jaydasika, 2016/06/24 21:54:44]

Done.

+  }
+
+  void BeginTest() override { PostSetNeedsCommitToMainThread(); }
+
+  void CommitCompleteOnThread(LayerTreeHostImpl* host_impl) override {
+    PropertyTrees* property_trees = host_impl->pending_tree()->property_trees();
+    TransformNode* node = property_trees->transform_tree.Node(
+        host_impl->pending_tree()->root_layer()->transform_tree_index());
+    gfx::Transform rotate10;
+    rotate10.Rotate(10);
+    switch (host_impl->pending_tree()->source_frame_number()) {
+      case 2:
+        EXPECT_NE(node->data.local, rotate10);
+        EndTest();
+        break;
+      default:
+        break;
+    }
+  }
+
+  void DidCommit() override { PostSetNeedsCommitToMainThread(); }
+
+  void UpdateLayerTreeHost() override {

[ajuma, 2016/06/24 21:02:34]

How about doing this in WillBeginMainFrame? Then the animation will get ticked
(I think) at its starting point on the main thread, so you won't need to set a
rotation below in order to change the main thread transform.

[jaydasika, 2016/06/24 21:54:44]

Done.

+    if (layer_tree_host()->source_frame_number() == 2) {
+      // Destroy player.
+      timeline_->DetachPlayer(player_.get());
+      player_ = nullptr;
+      timeline_->AttachPlayer(player_child_.get());
+      player_child_->AttachElement(layer_tree_host()->root_layer()->id());
+      AddAnimatedTransformToPlayer(player_child_.get(), 1.0, 5, 5);
+      Animation* animation = player_child_->element_animations()->GetAnimation(
+          TargetProperty::TRANSFORM);
+      animation->set_start_time(base::TimeTicks::Now() +
+                                base::TimeDelta::FromSecondsD(1000));
+      animation->set_fill_mode(Animation::FillMode::NONE);
+      animation->InEffect(base::TimeTicks::Now());

[jaydasika, 2016/06/24 20:47:43]

Will remove this.

+      gfx::Transform rotate10;
+      rotate10.Rotate(10);
+      layer_tree_host()->root_layer()->SetTransform(rotate10);
+    }
+  }
+
+  void AfterTest() override {}
+};
+
+MULTI_THREAD_TEST_F(LayerTreeHostAnimationTestChangeAnimationPlayer);

[ajuma, 2016/06/24 21:02:34]

Can this be a single thread test too? (using sync_tree instead of pending_tree
in CommitCompleteOnThread)

[jaydasika, 2016/06/24 21:54:44]

Done.

+
 // Check that SetTransformIsPotentiallyAnimatingChanged is called
 // if we destroy ElementAnimations.
 class LayerTreeHostAnimationTestSetPotentiallyAnimatingOnLacDestruction
     : public LayerTreeHostAnimationTest {
  public:
   void SetupTree() override {
     prev_screen_space_transform_is_animating_ = true;
     screen_space_transform_animation_stopped_ = false;
 
     LayerTreeHostAnimationTest::SetupTree();
@@ skipping 113 matching lines @@
  private:
   scoped_refptr<Layer> layer_;
   FakeContentLayerClient client_;
 };
 
 MULTI_THREAD_TEST_F(
     LayerTreeHostAnimationTestRebuildPropertyTreesOnAnimationSetNeedsCommit);
 
 }  // namespace
 }  // namespace cc