Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6694)

Unified Diff: chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc

Issue 2090773002: Improves first run dialog performance on Win8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cr Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
diff --git a/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc b/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..eef4638710b613649a18b4f1aa9cb38d5ea3daee
--- /dev/null
+++ b/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
@@ -0,0 +1,60 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/set_as_default_browser_ui_win.h"
+
+#include "base/command_line.h"
+#include "base/win/windows_version.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "ui/views/widget/widget.h"
+
+namespace {
+
+bool IsBrowserVisible(Browser* browser) {
+ return views::Widget::GetWidgetForNativeWindow(
+ browser->window()->GetNativeWindow())
+ ->IsVisible();
+}
+
+} // namespace
+
+using SetAsDefaultBrowserUIBrowserTestWithoutFirstRun = InProcessBrowserTest;
+
+class SetAsDefaultBrowserUIBrowserTestWithFirstRun
+ : public InProcessBrowserTest {
+ public:
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ InProcessBrowserTest::SetUpCommandLine(command_line);
+ command_line->AppendSwitch(switches::kForceFirstRun);
+ }
+
+ protected:
+ void TearDownInProcessBrowserTestFixture() override {
+ ASSERT_FALSE(SetAsDefaultBrowserUI::GetDialogWidgetForTesting());
+ }
+};
+
+IN_PROC_BROWSER_TEST_F(SetAsDefaultBrowserUIBrowserTestWithFirstRun, Test) {
+ // Windows 8 only test case.
+ if (base::win::GetVersion() <= base::win::VERSION_WIN7 ||
+ base::win::GetVersion() >= base::win::VERSION_WIN10) {
+ return;
+ }
+ ASSERT_FALSE(IsBrowserVisible(browser()));
+ views::Widget* dialog_widget =
+ SetAsDefaultBrowserUI::GetDialogWidgetForTesting();
+ ASSERT_TRUE(dialog_widget);
+ ASSERT_TRUE(dialog_widget->IsVisible());
+ dialog_widget->CloseNow();
+ ASSERT_TRUE(IsBrowserVisible(browser()));
+}
+
+IN_PROC_BROWSER_TEST_F(SetAsDefaultBrowserUIBrowserTestWithoutFirstRun,
+ TestWithoutFirstRun) {
+ ASSERT_TRUE(IsBrowserVisible(browser()));
+ EXPECT_EQ(nullptr, SetAsDefaultBrowserUI::GetDialogWidgetForTesting());
+}
« no previous file with comments | « chrome/browser/ui/webui/set_as_default_browser_ui.cc ('k') | chrome/browser/ui/webui/set_as_default_browser_ui_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698