Improves first run dialog performance on Win8

chrome/browser/ui/startup/default_browser_prompt_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/default_browser_prompt.h"
 
 #include "base/macros.h"
 #include "base/win/windows_version.h"
+#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/webui/set_as_default_browser_ui.h"
-#include "components/prefs/pref_service.h"
 #include "components/startup_metric_utils/browser/startup_metric_utils.h"
-#include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
-#include "content/public/browser/notification_types.h"
-
-using content::BrowserThread;
 
 namespace {
 
 // Show the page prompting the user to make Chrome the default browser on
 // Windows 8 (which means becoming "the browser" in Metro mode). The page
 // will be shown at the first appropriate opportunity. It can be placed in
 // a tab or in a dialog, depending on other settings.
 class SetMetroBrowserFlowLauncher : public content::NotificationObserver {
  public:
   static void LaunchSoon(Profile* profile) {
     // The instance will manage its own lifetime.
     new SetMetroBrowserFlowLauncher(profile);
   }
 
  private:
   explicit SetMetroBrowserFlowLauncher(Profile* profile)
       : profile_(profile) {
-    registrar_.Add(this, content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
+    registrar_.Add(this, chrome::NOTIFICATION_BROWSER_WINDOW_READY,

[sky, 2016/07/06 19:21:18]

Use a BrowserListObserver instead of notification as notifications are
deprecated.

[zmin, 2016/07/06 20:04:30]

Ok, I thought only the notification type with "deprecated" in comments are
deprecated but didn't aware of that all notifications are deprecated.

                    content::NotificationService::AllSources());
   }
 
   // content::NotificationObserver override:
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override;
 
   content::NotificationRegistrar registrar_;
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(SetMetroBrowserFlowLauncher);
 };
 
 void SetMetroBrowserFlowLauncher::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
-  DCHECK_EQ(content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME, type);
+  DCHECK_EQ(chrome::NOTIFICATION_BROWSER_WINDOW_READY, type);
 
-  Browser* browser = chrome::FindBrowserWithWebContents(
-      content::Source<content::WebContents>(source).ptr());
+  Browser* browser = content::Source<Browser>(source).ptr();
   if (!browser || !browser->is_type_tabbed())
     return;
 
   // Unregister and delete.
   registrar_.RemoveAll();
   SetAsDefaultBrowserUI::Show(profile_, browser);
   delete this;
 }
 
 }  // namespace
@@ skipping 16 matching lines @@
 
   if (show_status) {
     startup_metric_utils::SetNonBrowserUIDisplayed();
     SetMetroBrowserFlowLauncher::LaunchSoon(profile);
   }
 
   return show_status;
 }
 
 }  // namespace chrome