[MD settings] end of page padding in content area

chrome/browser/resources/settings/settings_main/settings_main.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-main' displays the selected settings page.
  */
 Polymer({
   is: 'settings-main',
@@ skipping 45 matching lines @@
     showAboutPage_: {
       type: Boolean,
       value: false,
     },
   },
 
   attached: function() {
     document.addEventListener('toggle-advanced-page', function(e) {
       this.showAdvancedPage_ = e.detail;
       this.isAdvancedMenuOpen_ = e.detail;
+      this.currentRoute = {

[Dan Beam, 2016/06/23 02:48:21]

why is this necessary?

[dschuyler, 2016/06/23 18:33:10]

The route was not being correctly set.
This could be moved to a separate CL.
I'll update the CL notes to mention that
this is here.

+        page: this.isAdvancedMenuOpen_ ? 'advanced' : 'basic',
+        section: '',
+        subpage: [],
+        url: '',
+      };
       if (this.showAdvancedPage_) {
         scrollWhenReady(
             function() {
               return this.$$('settings-advanced-page');
             }.bind(this),
             function() {
               return this.$$('#toggleContainer');
             }.bind(this));
       }
     }.bind(this));
@@ skipping 19 matching lines @@
 
     this.showAdvancedToggle_ = !this.showAboutPage_ && !isSubpage;
 
     this.showBasicPage_ = this.showAdvancedToggle_ || newRoute.page == 'basic';
 
     this.showAdvancedPage_ =
         (this.isAdvancedMenuOpen_ && this.showAdvancedToggle_) ||
         newRoute.page == 'advanced';
 
     this.style.height = isSubpage ? '100%' : '';
+
+    this.$.endOfPageSpace.style.paddingBottom =
+        (this.parentNode.scrollHeight - this.lastSettingsElementHeight_()) +
+        'px';
+  },
+
+  /**
+   * Height of the element including margin sizes.
+   * @param {Element} element
+   * @return {number}
+   * @private
+   */
+  calcHeight_: function(element) {
+    var style = getComputedStyle(element);
+    return element.offsetHeight + parseFloat(style.marginTop) +
+        parseFloat(style.marginBottom);
+  },
+
+  /**
+   * Return the height of the last item in the settings content area. Used to
+   * determine how much padding to apply to the end of the content so that the
+   * last element may align with the top of the content area.
+   * @return {number}
+   * @private
+   */
+  lastSettingsElementHeight_: function() {

[Dan Beam, 2016/06/23 02:48:21]

can calcHeight_ just live inside here instead as a pure function, i.e.

function calcHeight() {
}

[dschuyler, 2016/06/23 18:33:10]

Done.

+    Polymer.dom.flush();
+    if (!this.currentRoute || this.currentRoute.subpage.length != 0 ||
+        this.showAboutPage_)

[Dan Beam, 2016/06/23 02:48:21]

all these conditionals are more than 1 line in the conditional or the body, so
they should all have curlies

[dschuyler, 2016/06/23 18:33:10]

Done.

+      return 0;
+    if (this.showAdvancedPage_)
+      return this.calcHeight_(this.$$('settings-advanced-page').$$(
+                              '[section=reset]'));
+    if (this.$$('#toggleContainer'))

[Dan Beam, 2016/06/23 02:48:21]

don't query this twice, i.e.

var toggleContainer = this.$$('#toggleContainer');
if (toggleContainer)
  return calcHeight(toggleContainer);

[dschuyler, 2016/06/23 18:33:10]

Done.

+      return this.calcHeight_(this.$$('#toggleContainer'));
+    return 0;
   },
 
   /** @private */
   toggleAdvancedPage_: function() {
     this.fire('toggle-advanced-page', !this.isAdvancedMenuOpen_);
   },
 });