Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2090743004: android bb: Stop passing --buildtool=ninja (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android bb: Stop passing --buildtool=ninja No intended behavior change. BUG=622768 Committed: https://crrev.com/50e9dfa629b4df812e8c42ef5c0ad8237b36f333 Cr-Commit-Position: refs/heads/master@{#401919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/android/buildbot/bb_host_steps.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 6 months ago (2016-06-23 16:48:13 UTC) #2
mikecase (-- gone --)
oops, look at this yesterday but forgot to give lgtm, lgtm
4 years, 6 months ago (2016-06-24 17:53:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090743004/1
4 years, 6 months ago (2016-06-24 17:57:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 19:10:05 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 19:11:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50e9dfa629b4df812e8c42ef5c0ad8237b36f333
Cr-Commit-Position: refs/heads/master@{#401919}

Powered by Google App Engine
This is Rietveld 408576698