Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: src/objects.cc

Issue 2090723005: [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 1653247d9b653a2c839b883608ac4b6c8bb56eed..928d345c1ff4b2b3c7afcf4a22b0a9a2b7499f45 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -12654,6 +12654,12 @@ void Script::SetEvalOrigin(Handle<Script> script,
// current activation. Do not translate the code offset into source
// position, but store it as negative value for lazy translation.
StackTraceFrameIterator it(script->GetIsolate());
+
+ // Skip the topmost builtin exit frame.
+ if (!it.done() && it.is_builtin_exit()) {
+ it.Advance();
+ }
+
if (!it.done() && it.is_javascript()) {
FrameSummary summary = FrameSummary::GetFirst(it.javascript_frame());
script->set_eval_from_shared(summary.function()->shared());

Powered by Google App Engine
This is Rietveld 408576698