src/debug/liveedit.cc - Issue 2090723005: [builtins] New frame type for exits to C++ builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/liveedit.cc

Issue 2090723005: [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/liveedit.cc

diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc

index aa675374b51d88d34e8a0441c1c4b2fd98cb30f1..4b2bff053e0dbb84df2232fd21ed54bd145d9b56 100644

--- a/src/debug/liveedit.cc

+++ b/src/debug/liveedit.cc

@@ -1682,7 +1682,7 @@ static const char* DropActivationsInActiveThreadImpl(Isolate* isolate,

for (; frame_index < frames.length(); frame_index++) {

StackFrame* frame = frames[frame_index];

- if (frame->is_exit()) {

+ if (frame->is_exit() || frame->is_builtin_exit()) {

non_droppable_frame_found = true;

non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE;

break;