src/arm/code-stubs-arm.cc - Issue 2090723005: [builtins] New frame type for exits to C++ builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.cc

Issue 2090723005: [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/code-stubs-arm.cc

diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc

index 0ef31d7dfeb0cafa977142906b61615a761e5180..0f7a35a17fcbd994564e098d691c349837878a58 100644

--- a/src/arm/code-stubs-arm.cc

+++ b/src/arm/code-stubs-arm.cc

@@ -950,7 +950,9 @@ void CEntryStub::Generate(MacroAssembler* masm) {

// Enter the exit frame that transitions from JavaScript to C++.

FrameScope scope(masm, StackFrame::MANUAL);

- __ EnterExitFrame(save_doubles());

+ __ EnterExitFrame(save_doubles(), 0, is_builtin_exit()

+ ? StackFrame::BUILTIN_EXIT

+ : StackFrame::EXIT);

// Store a copy of argc in callee-saved registers for later.

__ mov(r4, Operand(r0));