| OLD | NEW |
| 1 // Copyright 2016 the V8 project authors. All rights reserved. | 1 // Copyright 2016 the V8 project authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 var thrower = { [Symbol.toPrimitive]: () => FAIL }; | 5 var thrower = { [Symbol.toPrimitive]: () => FAIL }; |
| 6 | 6 |
| 7 // Tests that a native conversion function is included in the | 7 // Tests that a native conversion function is included in the |
| 8 // stack trace. | 8 // stack trace. |
| 9 function testTraceNativeConversion(nativeFunc) { | 9 function testTraceNativeConversion(nativeFunc) { |
| 10 var nativeFuncName = nativeFunc.name; | 10 var nativeFuncName = nativeFunc.name; |
| 11 try { | 11 try { |
| 12 nativeFunc(thrower); | 12 nativeFunc(thrower); |
| 13 assertUnreachable(nativeFuncName); | 13 assertUnreachable(nativeFuncName); |
| 14 } catch (e) { | 14 } catch (e) { |
| 15 assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName); | 15 assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName); |
| 16 } | 16 } |
| 17 } | 17 } |
| 18 | 18 |
| 19 testTraceNativeConversion(Math.max); | 19 testTraceNativeConversion(Math.max); |
| 20 testTraceNativeConversion(Math.min); | 20 testTraceNativeConversion(Math.min); |
| 21 | 21 |
| 22 function testBuiltinInStackTrace(script, nativeFuncName) { | 22 // C++ builtins. |
| 23 testTraceNativeConversion(Math.acos); |
| 24 testTraceNativeConversion(Math.asin); |
| 25 testTraceNativeConversion(Math.fround); |
| 26 testTraceNativeConversion(Math.imul); |
| 27 |
| 28 |
| 29 function testBuiltinInStackTrace(script, expectedString) { |
| 23 try { | 30 try { |
| 24 eval(script); | 31 eval(script); |
| 25 assertUnreachable(nativeFuncName); | 32 assertUnreachable(expectedString); |
| 26 } catch (e) { | 33 } catch (e) { |
| 27 assertTrue(e.stack.indexOf(nativeFuncName) >= 0, nativeFuncName); | 34 assertTrue(e.stack.indexOf(expectedString) >= 0, expectedString); |
| 28 } | 35 } |
| 29 } | 36 } |
| 30 | 37 |
| 31 // Use the full name ('String.getDate') in order to avoid false pass | 38 // Use the full name ('String.getDate') in order to avoid false pass |
| 32 // results when the method name is mentioned in the error message itself. | 39 // results when the method name is mentioned in the error message itself. |
| 33 // This occurs, e.g., for Date.prototype.getYear, which uses a different code | 40 // This occurs, e.g., for Date.prototype.getYear, which uses a different code |
| 34 // path and never hits the Generate_DatePrototype_GetField builtin. | 41 // path and never hits the Generate_DatePrototype_GetField builtin. |
| 35 testBuiltinInStackTrace("Date.prototype.getDate.call('')", "String.getDate"); | 42 testBuiltinInStackTrace("Date.prototype.getDate.call('')", "at String.getDate"); |
| 36 testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')", | 43 testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')", |
| 37 "String.getUTCDate"); | 44 "at String.getUTCDate"); |
| 38 testBuiltinInStackTrace("Date.prototype.getTime.call('')", "String.getTime"); | 45 testBuiltinInStackTrace("Date.prototype.getTime.call('')", "at String.getTime"); |
| 46 |
| 47 // C++ builtins. |
| 48 testBuiltinInStackTrace("Boolean.prototype.toString.call(thrower);", |
| 49 "at toString"); |
| 50 testBuiltinInStackTrace("new Date(thrower);", "at Date"); |
| OLD | NEW |