Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/debug/liveedit.cc

Issue 2090723005: [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add missing condition in SafeStackFrameIter::frame() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/counters.cc ('k') | src/external-reference-table.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/liveedit.h" 5 #include "src/debug/liveedit.h"
6 6
7 #include "src/ast/scopeinfo.h" 7 #include "src/ast/scopeinfo.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/compilation-cache.h" 10 #include "src/compilation-cache.h"
(...skipping 1626 matching lines...) Expand 10 before | Expand all | Expand 10 after
1637 return target.GetNotFoundMessage(); 1637 return target.GetNotFoundMessage();
1638 } 1638 }
1639 1639
1640 bool target_frame_found = false; 1640 bool target_frame_found = false;
1641 int bottom_js_frame_index = top_frame_index; 1641 int bottom_js_frame_index = top_frame_index;
1642 bool non_droppable_frame_found = false; 1642 bool non_droppable_frame_found = false;
1643 LiveEdit::FunctionPatchabilityStatus non_droppable_reason; 1643 LiveEdit::FunctionPatchabilityStatus non_droppable_reason;
1644 1644
1645 for (; frame_index < frames.length(); frame_index++) { 1645 for (; frame_index < frames.length(); frame_index++) {
1646 StackFrame* frame = frames[frame_index]; 1646 StackFrame* frame = frames[frame_index];
1647 if (frame->is_exit()) { 1647 if (frame->is_exit() || frame->is_builtin_exit()) {
1648 non_droppable_frame_found = true; 1648 non_droppable_frame_found = true;
1649 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE; 1649 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE;
1650 break; 1650 break;
1651 } 1651 }
1652 if (frame->is_java_script()) { 1652 if (frame->is_java_script()) {
1653 SharedFunctionInfo* shared = 1653 SharedFunctionInfo* shared =
1654 JavaScriptFrame::cast(frame)->function()->shared(); 1654 JavaScriptFrame::cast(frame)->function()->shared();
1655 if (shared->is_resumable()) { 1655 if (shared->is_resumable()) {
1656 non_droppable_frame_found = true; 1656 non_droppable_frame_found = true;
1657 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR; 1657 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR;
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
2022 scope_info_length++; 2022 scope_info_length++;
2023 2023
2024 current_scope = current_scope->outer_scope(); 2024 current_scope = current_scope->outer_scope();
2025 } 2025 }
2026 2026
2027 return scope_info_list; 2027 return scope_info_list;
2028 } 2028 }
2029 2029
2030 } // namespace internal 2030 } // namespace internal
2031 } // namespace v8 2031 } // namespace v8
OLDNEW
« no previous file with comments | « src/counters.cc ('k') | src/external-reference-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698