net/ftp/ftp_directory_listing_parser_vms.cc - Issue 2090713003: Make callers of FromUTC(Local)Exploded in net/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_directory_listing_parser_vms.cc

Issue 2090713003: Make callers of FromUTC(Local)Exploded in net/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ftp/ftp_directory_listing_parser_vms.cc

diff --git a/net/ftp/ftp_directory_listing_parser_vms.cc b/net/ftp/ftp_directory_listing_parser_vms.cc

index 1a4e4360dcb438f82d428f6cf4b7f6da05c04db7..993a0dfe3de95f11ba1e0bc3f6b9eadc6f3b7341 100644

--- a/net/ftp/ftp_directory_listing_parser_vms.cc

+++ b/net/ftp/ftp_directory_listing_parser_vms.cc

@@ -192,9 +192,8 @@ bool VmsDateListingToTime(const std::vector<base::string16>& columns,

if (!base::StringToInt(time_parts[1], &time_exploded.minute))

return false;

- // We don't know the time zone of the server, so just use UTC.

- *time = base::Time::FromUTCExploded(time_exploded);

- return true;

+ // We don't know the time zone of the server, so just use local UTC.

eroman 2016/12/19 22:42:35 Please undo this comment change.

maksims (do not use this acc) 2016/12/20 12:32:49 Done.

+ return base::Time::FromUTCExploded(time_exploded, time);

}

} // namespace

« no previous file with comments | « net/ftp/ftp_directory_listing_parser_unittest.cc ('k') | net/ftp/ftp_util.cc » ('j') | no next file with comments »