Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: net/ftp/ftp_util.cc

Issue 2090713003: Make callers of FromUTC(Local)Exploded in net/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ftp/ftp_util.cc
diff --git a/net/ftp/ftp_util.cc b/net/ftp/ftp_util.cc
index 00b23b7c10b771daea8da81324fbc4fcc9f4249a..30b7042c2f530f27776b82083bf872c3670bea3a 100644
--- a/net/ftp/ftp_util.cc
+++ b/net/ftp/ftp_util.cc
@@ -286,7 +286,9 @@ bool FtpUtil::LsDateListingToTime(const base::string16& month,
}
// We don't know the time zone of the listing, so just use local time.
- *result = base::Time::FromLocalExploded(time_exploded);
+ if (!base::Time::FromLocalExploded(time_exploded, result)) {
+ return false;
+ }
return true;
}
@@ -348,8 +350,10 @@ bool FtpUtil::WindowsDateListingToTime(const base::string16& date,
}
}
- // We don't know the time zone of the server, so just use local time.
- *result = base::Time::FromLocalExploded(time_exploded);
+ // We don't know the time zone of the listing, so just use local time.
+ if (!base::Time::FromLocalExploded(time_exploded, result)) {
+ return false;
+ }
return true;
}

Powered by Google App Engine
This is Rietveld 408576698