Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: net/ftp/ftp_util.cc

Issue 2090713003: Make callers of FromUTC(Local)Exploded in net/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_vms.cc ('k') | net/http/http_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_util.cc
diff --git a/net/ftp/ftp_util.cc b/net/ftp/ftp_util.cc
index 00b23b7c10b771daea8da81324fbc4fcc9f4249a..40dc040cccbf1a34195443975d79b0f451d54c28 100644
--- a/net/ftp/ftp_util.cc
+++ b/net/ftp/ftp_util.cc
@@ -286,8 +286,7 @@ bool FtpUtil::LsDateListingToTime(const base::string16& month,
}
// We don't know the time zone of the listing, so just use local time.
maksims (do not use this acc) 2016/10/05 12:59:02 Problem is with this one. The guess is bad, actual
- *result = base::Time::FromLocalExploded(time_exploded);
- return true;
+ return base::Time::FromLocalExploded(time_exploded, result);
}
// static
@@ -349,8 +348,7 @@ bool FtpUtil::WindowsDateListingToTime(const base::string16& date,
}
// We don't know the time zone of the server, so just use local time.
- *result = base::Time::FromLocalExploded(time_exploded);
- return true;
+ return base::Time::FromLocalExploded(time_exploded, result);
}
// static
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_vms.cc ('k') | net/http/http_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698