net/cert/x509_cert_types.cc - Issue 2090713003: Make callers of FromUTC(Local)Exploded in net/ use new time API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/cert/x509_cert_types.cc

Issue 2090713003: Make callers of FromUTC(Local)Exploded in net/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert ftp_util Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/cert/x509_cert_types.h"	5 #include "net/cert/x509_cert_types.h"

6	6

7 #include <cstdlib>	7 #include <cstdlib>

8 #include <cstring>	8 #include <cstring>

9	9

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 exploded.minute = ParseIntAndAdvance(&field, 2, &valid);	69 exploded.minute = ParseIntAndAdvance(&field, 2, &valid);

70 exploded.second = ParseIntAndAdvance(&field, 2, &valid);	70 exploded.second = ParseIntAndAdvance(&field, 2, &valid);

71 if (valid && year_length == 2)	71 if (valid && year_length == 2)

72 exploded.year += exploded.year < 50 ? 2000 : 1900;	72 exploded.year += exploded.year < 50 ? 2000 : 1900;

73	73

74 valid &= exploded.HasValidValues();	74 valid &= exploded.HasValidValues();

75	75

76 if (!valid)	76 if (!valid)

77 return false;	77 return false;

78	78

79 *time = base::Time::FromUTCExploded(exploded);	79 // FromUTCExploded() can fail even though exploded.HasValidValues()

80 return true;	80 // returned true.

	81 return base::Time::FromUTCExploded(exploded, time);

81 }	82 }

82	83

83 } // namespace net	84 } // namespace net

OLD	NEW

« no previous file with comments | « net/cert/ct_policy_enforcer_unittest.cc ('k') | net/cert/x509_cert_types_unittest.cc » ('j') | net/ftp/ftp_util.cc » ('J')