Make callers of FromUTC(Local)Exploded in net/ use new time API.

net/ftp/ftp_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_util.h"
 
 #include <map>
 #include <vector>
 
 #include "base/i18n/case_conversion.h"
@@ skipping 268 matching lines @@
     if (time_exploded.month > current_exploded.month ||
         (time_exploded.month == current_exploded.month &&
          time_exploded.day_of_month > current_exploded.day_of_month)) {
       time_exploded.year = current_exploded.year - 1;
     } else {
       time_exploded.year = current_exploded.year;
     }
   }
 
   // We don't know the time zone of the listing, so just use local time.
-  *result = base::Time::FromLocalExploded(time_exploded);
+  if (!base::Time::FromLocalExploded(time_exploded, result)) {

[eroman, 2016/10/27 21:44:34]

[optional] I suggest simplifying this to:

return base::Time::FromLocalExploded(...);

[maksims (do not use this acc), 2016/11/29 07:38:56]

Done.

+    return false;
+  }
   return true;
 }
 
 // static
 bool FtpUtil::WindowsDateListingToTime(const base::string16& date,
                                        const base::string16& time,
                                        base::Time* result) {
   base::Time::Exploded time_exploded = { 0 };
 
   // Date should be in format MM-DD-YY[YY].
@@ skipping 41 matching lines @@
       if (time_exploded.hour < 12)
         time_exploded.hour += 12;
     } else if (base::EqualsASCII(am_or_pm, "AM")) {
       if (time_exploded.hour == 12)
         time_exploded.hour = 0;
     } else {
       return false;
     }
   }
 
-  // We don't know the time zone of the server, so just use local time.
-  *result = base::Time::FromLocalExploded(time_exploded);
+  // We don't know the time zone of the listing, so just use local time.
+  if (!base::Time::FromLocalExploded(time_exploded, result)) {

[eroman, 2016/10/27 21:44:34]

Same

[maksims (do not use this acc), 2016/11/29 07:38:56]

Done.

+    return false;
+  }
   return true;
 }
 
 // static
 base::string16 FtpUtil::GetStringPartAfterColumns(const base::string16& text,
                                                   int columns) {
   base::i18n::UTF16CharIterator iter(&text);
 
   for (int i = 0; i < columns; i++) {
     // Skip the leading whitespace.
     while (!iter.end() && u_isspace(iter.get()))
       iter.Advance();
 
     // Skip the actual text of i-th column.
     while (!iter.end() && !u_isspace(iter.get()))
       iter.Advance();
   }
 
   base::string16 result(text.substr(iter.array_pos()));
   base::TrimWhitespace(result, base::TRIM_ALL, &result);
   return result;
 }
 
 }  // namespace net