Make callers of FromUTC(Local)Exploded in net/ use new time API.

net/cert/x509_cert_types.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/x509_cert_types.h"
 
 #include <cstdlib>
 #include <cstring>
 
 #include "base/logging.h"
@@ skipping 53 matching lines @@
 
   exploded.year =         ParseIntAndAdvance(&field, year_length, &valid);
   exploded.month =        ParseIntAndAdvance(&field, 2, &valid);
   exploded.day_of_month = ParseIntAndAdvance(&field, 2, &valid);
   exploded.hour =         ParseIntAndAdvance(&field, 2, &valid);
   exploded.minute =       ParseIntAndAdvance(&field, 2, &valid);
   exploded.second =       ParseIntAndAdvance(&field, 2, &valid);
   if (valid && year_length == 2)
     exploded.year += exploded.year < 50 ? 2000 : 1900;
 
   valid &= exploded.HasValidValues();

[eroman, 2016/10/27 21:44:34]

This line is redundant with the call to FromUTCExploded() below right?

[maksims (do not use this acc), 2016/11/29 07:38:56]

No. FromUTCExploded doesn't perform this kind of check.

[eroman, 2016/11/30 00:21:05]

FromUTCExploded() returns a boolean indicating success. It shouldn't be possible
for it to return true for inputs where !HasValidValues(), hence this is
redundant.

If you are aware of a situation where this is necessary please raise it as a
bug, since it means we aren't properly checking errors in FromUTCExploded()

[maksims (do not use this acc), 2016/12/05 13:15:49]

Sorry, I was wrong. it's ok to remove this line.

 
   if (!valid)
     return false;
 
-  *time = base::Time::FromUTCExploded(exploded);
-  return true;
+  // FromUTCExploded() can fail even though exploded.HasValidValues()
+  // returned true.
+  return base::Time::FromUTCExploded(exploded, time);
 }
 
 }  // namespace net