Make callers of FromUTC(Local)Exploded in net/ use new time API.

net/cookies/cookie_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cookies/cookie_util.h"
 
 #include <cstdio>
 #include <cstdlib>
 
 #include "base/logging.h"
@@ skipping 182 matching lines @@
     // NOTREACHED() << "Cookie parse expiration failed: " << time_string;
     return base::Time();
   }
 
   // Normalize the year to expand abbreviated years to the full year.
   if (exploded.year >= 69 && exploded.year <= 99)
     exploded.year += 1900;
   if (exploded.year >= 0 && exploded.year <= 68)
     exploded.year += 2000;
 
-  // If our values are within their correct ranges, we got our time.
   if (exploded.day_of_month >= 1 && exploded.day_of_month <= 31 &&

[eroman, 2016/10/20 18:05:21]

Can you remove this "if" statement?

FromUTCExploded() should already be doing this check internally.

-      exploded.month >= 1 && exploded.month <= 12 &&
-      exploded.year >= 1601 && exploded.year <= 30827 &&
-      exploded.hour <= 23 && exploded.minute <= 59 && exploded.second <= 59) {
-    return base::Time::FromUTCExploded(exploded);
+      exploded.month >= 1 && exploded.month <= 12 && exploded.year >= 1601 &&
+      exploded.year <= 30827 && exploded.hour <= 23 && exploded.minute <= 59 &&
+      exploded.second <= 59) {
+    // Time conversion can fail. See comments in base/time.h
+    base::Time out_time;
+    if (base::Time::FromUTCExploded(exploded, &out_time))
+      return out_time;
   }
 
   // One of our values was out of expected range.  For well-formed input,
   // the following check would be reasonable:
   // NOTREACHED() << "Cookie exploded expiration failed: " << time_string;
 
   return base::Time();
 }
 
 GURL CookieOriginToURL(const std::string& domain, bool is_https) {
@@ skipping 54 matching lines @@
       buffer.append("; ");
     buffer.append(i->first.begin(), i->first.end());
     buffer.push_back('=');
     buffer.append(i->second.begin(), i->second.end());
   }
   return buffer;
 }
 
 }  // namespace cookie_util
 }  // namespace net