Make callers of FromUTC(Local)Exploded in net/ use new time API.

net/cert/cert_verify_proc.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/cert_verify_proc.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 
@@ skipping 675 matching lines @@
   if (exploded_expiry.year - exploded_start.year > 10)
     return true;
 
   int month_diff = (exploded_expiry.year - exploded_start.year) * 12 +
                    (exploded_expiry.month - exploded_start.month);
 
   // Add any remainder as a full month.
   if (exploded_expiry.day_of_month > exploded_start.day_of_month)
     ++month_diff;
 
-  static const base::Time time_2012_07_01 =
-      base::Time::FromUTCExploded({2012, 7, 0, 1, 0, 0, 0, 0});
-  static const base::Time time_2015_04_01 =
-      base::Time::FromUTCExploded({2015, 4, 0, 1, 0, 0, 0, 0});
-  static const base::Time time_2019_07_01 =
-      base::Time::FromUTCExploded({2019, 7, 0, 1, 0, 0, 0, 0});
+  static base::Time time_2012_07_01;
+  if (!base::Time::FromUTCExploded({2012, 7, 0, 1, 0, 0, 0, 0},

[eroman, 2016/10/20 18:05:21]

This translation is not the same -- before FromUTCExploded() was run a single
time, whereas now it is run on each invocation of the function.

And in fact neither is correct, explained the problem here:
https://bugs.chromium.org/p/chromium/issues/detail?id=657903

I will fix this (https://codereview.chromium.org/2441713002/) so won't require
any changes in this CL.

+                                   &time_2012_07_01)) {
+    return false;
+  }
+
+  static base::Time time_2015_04_01;
+  if (!base::Time::FromUTCExploded({2015, 4, 0, 1, 0, 0, 0, 0},
+                                   &time_2015_04_01)) {
+    return false;
+  }
+
+  static base::Time time_2019_07_01;
+  if (!base::Time::FromUTCExploded({2019, 7, 0, 1, 0, 0, 0, 0},
+                                   &time_2019_07_01)) {
+    return false;
+  }
 
   // For certificates issued before the BRs took effect.
   if (start < time_2012_07_01 && (month_diff > 120 || expiry > time_2019_07_01))
     return true;
 
   // For certificates issued after 1 July 2012: 60 months.
   if (start >= time_2012_07_01 && month_diff > 60)
     return true;
 
   // For certificates issued after 1 April 2015: 39 months.
   if (start >= time_2015_04_01 && month_diff > 39)
     return true;
 
   return false;
 }
 
 }  // namespace net