net/quic/quic_http_stream.cc - Issue 2090703003: Change QuicHttpStream::OnError to look at both stream and connection errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_http_stream.cc

Issue 2090703003: Change QuicHttpStream::OnError to look at both stream and connection errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_http_stream.cc

diff --git a/net/quic/quic_http_stream.cc b/net/quic/quic_http_stream.cc

index d3fd026570810ccb184bacaf05b0e6455a234b9d..3217864a47450a17a2250782c0d9012386e5ff23 100644

--- a/net/quic/quic_http_stream.cc

+++ b/net/quic/quic_http_stream.cc

@@ -497,7 +497,8 @@ void QuicHttpStream::OnDataAvailable() {

}

void QuicHttpStream::OnClose(QuicErrorCode error) {

- if (error != QUIC_NO_ERROR) {

+ if (error != QUIC_NO_ERROR ||

+ stream_->stream_error() != QUIC_STREAM_NO_ERROR) {

response_status_ = was_handshake_confirmed_ ? ERR_QUIC_PROTOCOL_ERROR

: ERR_QUIC_HANDSHAKE_FAILED;

} else if (!response_headers_received_) {

« no previous file with comments | « no previous file | net/quic/quic_network_transaction_unittest.cc » ('j') | no next file with comments »