Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2090703003: Change QuicHttpStream::OnError to look at both stream and connection errors. (Closed)

Created:
4 years, 6 months ago by Ryan Hamilton
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change QuicHttpStream::OnError to look at both stream and connection errors. BUG=622537 Committed: https://crrev.com/cd5f1c60daa702f416e719edf13358571e0bf084 Cr-Commit-Position: refs/heads/master@{#401526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1 line) Patch
M net/quic/quic_http_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +103 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ryan Hamilton
rtenneti: PTAL ianswett: FYI
4 years, 6 months ago (2016-06-23 00:23:07 UTC) #2
ramant (doing other things)
lgtm
4 years, 6 months ago (2016-06-23 00:53:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090703003/1
4 years, 6 months ago (2016-06-23 01:27:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 02:44:07 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 02:48:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd5f1c60daa702f416e719edf13358571e0bf084
Cr-Commit-Position: refs/heads/master@{#401526}

Powered by Google App Engine
This is Rietveld 408576698