Chromium Code Reviews| Index: base/files/scoped_file.cc |
| diff --git a/base/files/scoped_file.cc b/base/files/scoped_file.cc |
| index 8971280776c6c946ec7d0b80d2cf4b2b84b208e6..8ce45b8ba39e5a09ec835bdbc3fd72f735788f4b 100644 |
| --- a/base/files/scoped_file.cc |
| +++ b/base/files/scoped_file.cc |
| @@ -8,8 +8,10 @@ |
| #include "build/build_config.h" |
| #if defined(OS_POSIX) |
| +#include <errno.h> |
| #include <unistd.h> |
| +#include "base/debug/alias.h" |
| #include "base/posix/eintr_wrapper.h" |
| #endif |
| @@ -27,7 +29,15 @@ void ScopedFDCloseTraits::Free(int fd) { |
| // Chrome relies on being able to "drop" such access. |
| // It's especially problematic on Linux with the setuid sandbox, where |
| // a single open directory would bypass the entire security model. |
| - PCHECK(0 == IGNORE_EINTR(close(fd))); |
| + int ret = IGNORE_EINTR(close(fd)); |
| + |
| + // TODO(davidben): Remove this once it's been determined whether |
| + // https://crbug.com/603354 is caused by EBADF or a network filesystem |
| + // returning some other error. |
| + int close_errno = errno; |
| + base::debug::Alias(&close_errno); |
| + |
| + PCHECK(0 == ret); |
|
Robert Sesek
2016/06/22 19:53:01
While you're here, PCHECK_EQ would be better.
davidben
2016/06/22 19:58:28
Done.
|
| } |
| #endif // OS_POSIX |