Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2090683004: Unbreak chrome://interstitials/ssl (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam, meacer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbreak chrome://interstitials/ssl https://crrev.com/401430 removed setting a certificate for the UI, as it was believed to be unnecessary. As it turns out, it is necessary to have a valid X509Certificate in the SSLInfo, and the unittests to ensure that are disabled as flaky. Unbreak this by minting a fake cert on the fly. BUG=526899, 622961 TEST=Open chrome://interstitials/ssl and see that nothing explodes in a fashion Michael Bay begrudgingly approve of. R=meacer@chromium.org Committed: https://crrev.com/38036ce8149c1ae43f76d78174d85febcceb9c76 Cr-Commit-Position: refs/heads/master@{#401960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M chrome/browser/ui/webui/interstitials/interstitial_ui.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 6 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ryan Sleevi
Oops Manually tested
4 years, 6 months ago (2016-06-24 03:33:03 UTC) #1
meacer
On 2016/06/24 03:33:03, Ryan Sleevi wrote: > Oops > > Manually tested > TEST=Open chrome://interstitials/ssl ...
4 years, 6 months ago (2016-06-24 17:28:42 UTC) #3
Ryan Sleevi
Dan for OWNERS stamp - didn't realize meacer didn't own this file.
4 years, 6 months ago (2016-06-24 17:52:17 UTC) #5
Dan Beam
rubbery lgtm to prevent your Transformers-style explosions
4 years, 6 months ago (2016-06-24 19:39:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090683004/1
4 years, 6 months ago (2016-06-24 19:47:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 20:49:27 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 20:51:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38036ce8149c1ae43f76d78174d85febcceb9c76
Cr-Commit-Position: refs/heads/master@{#401960}

Powered by Google App Engine
This is Rietveld 408576698