Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2090643002: Revert of Bring back compiling third_party/libpng in public.bzl (Closed)

Created:
4 years, 6 months ago by scroggo
Modified:
4 years, 6 months ago
Reviewers:
msarett, dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Bring back compiling third_party/libpng in public.bzl (patchset #3 id:40001 of https://codereview.chromium.org/2044703006/ ) Reason for revert: Breaking Google3 Original issue's description: > Bring back compiling third_party/libpng in public.bzl > > Disable the optimizations for simplicity, as suggested in [1]. > > Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. > > [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 > > Committed: https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce TBR=benjaminwagner@google.com,msarett@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/7732c0cae7403639ad0ce88b8f06d9030ee1ca84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M public.bzl View 4 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scroggo
Created Revert of Bring back compiling third_party/libpng in public.bzl
4 years, 6 months ago (2016-06-22 14:25:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090643002/1
4 years, 6 months ago (2016-06-22 14:25:13 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 14:25:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7732c0cae7403639ad0ce88b8f06d9030ee1ca84

Powered by Google App Engine
This is Rietveld 408576698