Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2090633002: Improving test coverage of Popup Zoomer (Closed)

Created:
4 years, 6 months ago by AKV
Modified:
4 years, 5 months ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improving test coverage of Popup Zoomer Added test coverage with device BACK key. BUG= Committed: https://crrev.com/3e1e75bb7bd0798a0354de3e4aea1a74a3af4283 Cr-Commit-Position: refs/heads/master@{#403415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
AKV
PTAL!
4 years, 6 months ago (2016-06-22 14:24:00 UTC) #2
AKV
friendly ping! PTAL!
4 years, 5 months ago (2016-06-29 18:17:31 UTC) #3
AKV
@Ted/Yaron - you missed this patch from reviewing :)
4 years, 5 months ago (2016-06-30 17:24:02 UTC) #4
Ted C
lgtm
4 years, 5 months ago (2016-06-30 17:28:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090633002/1
4 years, 5 months ago (2016-07-01 05:45:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 06:20:30 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 06:21:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e1e75bb7bd0798a0354de3e4aea1a74a3af4283
Cr-Commit-Position: refs/heads/master@{#403415}

Powered by Google App Engine
This is Rietveld 408576698