Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2090613002: Remove calls to deprecated MessageLoop methods in net. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in net. This CL makes the following replacements in net: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=agl@chromium.org Committed: https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2 Cr-Commit-Position: refs/heads/master@{#401297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -66 lines) Patch
M net/base/network_config_watcher_mac.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/dns/dns_config_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/dns/dns_transaction_unittest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M net/dns/host_resolver_impl_unittest.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M net/dns/serial_worker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/mock_proxy_script_fetcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 20 chunks +20 lines, -20 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/gdig/gdig.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/synchronous_host_resolver.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_job_factory_impl_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:44:20 UTC) #1
agl
lgtm
4 years, 6 months ago (2016-06-22 16:06:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090613002/1
4 years, 6 months ago (2016-06-22 16:06:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 16:11:45 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 16:12:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eeb764832f20a297cdce834432ebfe44acc59d2
Cr-Commit-Position: refs/heads/master@{#401297}

Powered by Google App Engine
This is Rietveld 408576698