Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2090603002: Remove calls to deprecated MessageLoop methods in mojo. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in mojo. This CL makes the following replacements in mojo: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 TBR=ben@chromium.org Committed: https://crrev.com/9c3a37991068030209c185e450faf4b37279186d Cr-Commit-Position: refs/heads/master@{#402560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:44:25 UTC) #1
fdoray
+sky@ ben@ or sky@: Can you review this CL? Thanks.
4 years, 5 months ago (2016-06-28 20:15:32 UTC) #3
Ben Goodger (Google)
lgtm. if you get more than 24hrs of latency from me feel free to ping ...
4 years, 5 months ago (2016-06-28 20:16:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090603002/1
4 years, 5 months ago (2016-06-28 20:18:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 21:59:48 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:02:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c3a37991068030209c185e450faf4b37279186d
Cr-Commit-Position: refs/heads/master@{#402560}

Powered by Google App Engine
This is Rietveld 408576698