chrome/browser/ui/passwords/manage_passwords_state_unittest.cc - Issue 2090583003: Introduce password_manager::FormSaver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

Issue 2090583003: Introduce password_manager::FormSaver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

index e2e7bca71d9287dbb43c0984e757e01975e85477..e7744207207d9766f0d4281d3210133952e1be97 100644

--- a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

@@ -11,6 +11,7 @@

#include "base/strings/utf_string_conversions.h"

#include "components/password_manager/core/browser/password_form_manager.h"

#include "components/password_manager/core/browser/password_manager.h"

+#include "components/password_manager/core/browser/stub_form_saver.h"

#include "components/password_manager/core/browser/stub_password_manager_client.h"

#include "components/password_manager/core/browser/stub_password_manager_driver.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -118,7 +119,8 @@ ManagePasswordsStateTest::CreateFormManagerInternal(bool include_federated) {

std::unique_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

&password_manager_, &stub_client_, driver_.AsWeakPtr(),

- test_local_form(), false));

+ test_local_form(), false,

+ base::WrapUnique(new password_manager::StubFormSaver)));

test_form_manager->SimulateFetchMatchingLoginsFromPasswordStore();

if (include_federated) {

test_stored_forms_.push_back(