Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2090543002: Revert of 🎂 Refactor process_resources.py to use aapt's --extra-packages (Closed)

Created:
4 years, 6 months ago by perezju
Modified:
4 years, 6 months ago
Reviewers:
Peter Wen, agrieve, smaier
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🎂 Refactor process_resources.py to use aapt's --extra-packages (patchset #8 id:140001 of https://codereview.chromium.org/2081473002/ ) Reason for revert: Broke internal android bots https://crbug.com/622212 Original issue's description: > Refactor process_resources.py to use aapt's --extra-packages > > We actually never pass --include-all-resources, so this is just > refactoring dead code. I think it's an improvement though, > as the new comments explain more of why things work the way they do. > > BUG=none > > Committed: https://crrev.com/9882d61c25bbebe84e82a7d559cae6f0807a4775 > Cr-Commit-Position: refs/heads/master@{#401165} TBR=smaier@chromium.org,wnwen@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/1483bad27eb01f8f4980be7adf55fc96de0fda5d Cr-Commit-Position: refs/heads/master@{#401240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -101 lines) Patch
M build/android/gyp/process_resources.py View 7 chunks +81 lines, -101 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perezju
Created Revert of 🎂 Refactor process_resources.py to use aapt's --extra-packages
4 years, 6 months ago (2016-06-22 09:32:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090543002/1
4 years, 6 months ago (2016-06-22 09:33:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 09:33:48 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 09:35:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1483bad27eb01f8f4980be7adf55fc96de0fda5d
Cr-Commit-Position: refs/heads/master@{#401240}

Powered by Google App Engine
This is Rietveld 408576698