ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js - Issue 2090513002: MD Search Field: Properly respond to external changes to search value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

Issue 2090513002: MD Search Field: Properly respond to external changes to search value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweak test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js ('k') | ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

diff --git a/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

index d61cd6505b077a096159134fedef33a5c0c58b23..5c74246e99b584f333379f9b323e7f57f5039875 100644

--- a/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

+++ b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

@@ -27,8 +27,6 @@ var CrSearchFieldBehavior = {

reflectToAttribute: true

- hasSearchText: Boolean,

/** @private */

lastValue_: {

type: String,

@@ -78,7 +76,6 @@ var CrSearchFieldBehavior = {

if (newValue == this.lastValue_)

return;

- this.hasSearchText = newValue != '';

this.fire('search-changed', newValue);

this.lastValue_ = newValue;