Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2090493002: [turbofan] x - y < 0 is not equivalent to x < y. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, georgia.kouveli
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] x - y < 0 is not equivalent to x < y. We cannot change x - y < 0 to x < y, because it would only be safe if x - y cannot overflow, which we don't know in general. R=jarin@chromium.org BUG=v8:5129 Committed: https://crrev.com/488d6e5f844c126869af09ece8aa5428d1961c25 Cr-Commit-Position: refs/heads/master@{#37164}

Patch Set 1 #

Patch Set 2 : Fix cctests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M src/compiler/machine-operator-reducer.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
A + test/mjsunit/compiler/regress-5129.js View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-22 04:04:46 UTC) #1
Benedikt Meurer
Hey Jaro, Removing an invalid optimization from TurboFan. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-22 04:06:15 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-22 04:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090493002/20001
4 years, 6 months ago (2016-06-22 04:45:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 05:35:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 05:38:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/488d6e5f844c126869af09ece8aa5428d1961c25
Cr-Commit-Position: refs/heads/master@{#37164}

Powered by Google App Engine
This is Rietveld 408576698