Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2090483002: swarmbucket: add execution_timeout_secs (Closed)

Created:
4 years, 6 months ago by nodir1
Modified:
4 years, 6 months ago
Reviewers:
Vadim Sh., nodir
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

swarmbucket: add execution_timeout_secs It allows to set a timeout on swarming task execution. R=vadimsh@chromium.org BUG=622104 Committed: https://chromium.googlesource.com/infra/infra/+/117435c6caad58aae235bc3a3b60e6abbbb88696

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -16 lines) Patch
M appengine/cr-buildbucket/proto/project_config.proto View 1 chunk +3 lines, -0 lines 2 comments Download
M appengine/cr-buildbucket/proto/project_config_pb2.py View 6 chunks +14 lines, -7 lines 0 comments Download
M appengine/cr-buildbucket/swarming/swarming.py View 1 chunk +3 lines, -0 lines 0 comments Download
M appengine/cr-buildbucket/swarming/test/swarming_test.py View 3 chunks +29 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nodir
PTAL
4 years, 6 months ago (2016-06-22 03:45:06 UTC) #2
Vadim Sh.
lgtm https://codereview.chromium.org/2090483002/diff/1/appengine/cr-buildbucket/proto/project_config.proto File appengine/cr-buildbucket/proto/project_config.proto (right): https://codereview.chromium.org/2090483002/diff/1/appengine/cr-buildbucket/proto/project_config.proto#newcode61 appengine/cr-buildbucket/proto/project_config.proto:61: optional int32 execution_timeout_secs = 7; what happened to ...
4 years, 6 months ago (2016-06-22 19:41:28 UTC) #3
nodir
https://codereview.chromium.org/2090483002/diff/1/appengine/cr-buildbucket/proto/project_config.proto File appengine/cr-buildbucket/proto/project_config.proto (right): https://codereview.chromium.org/2090483002/diff/1/appengine/cr-buildbucket/proto/project_config.proto#newcode61 appengine/cr-buildbucket/proto/project_config.proto:61: optional int32 execution_timeout_secs = 7; On 2016/06/22 19:41:28, Vadim ...
4 years, 6 months ago (2016-06-22 22:00:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090483002/1
4 years, 6 months ago (2016-06-22 22:00:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 22:19:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/117435c6caad58aae235bc3a3b60e...

Powered by Google App Engine
This is Rietveld 408576698